Fix unused Abyss Jewel deletion #4057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. and optimize FindSocketedJewel behavior in a few different locations.
|
Apologies. While the default item set is current, it appears to work, but switch to "Starter" and the Abyss jewel is deleted X |
|
I have a PR in waiting soon to be ready and then found yours, if your busy i'll just merge current dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4045.
Description of the problem being solved:
This fixes a bug where the "Delete Unused" button in the items tab would delete Abyss Jewels socketed in equipment slots, as they were never being checked due to flawed logic. It also optimizes FindSocketedJewel behavior in a few different locations, making the Delete Unused button more responsive.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pastebin.com/ng1CBVN1