Add support for Holy Relic Nova triggering #4051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires77
approved these changes
Feb 11, 2022
Nostrademous
suggested changes
Feb 11, 2022
src/Modules/CalcPerform.lua
Outdated
| breakdown = env.minion.breakdown | ||
| output = env.minion.output | ||
|
|
||
| trigRate = calcActualTriggerRate(env, source, sourceAPS, spellCount, output, breakdown, false, true) |
There was a problem hiding this comment.
Is there a reason:
trigRate = calcActualTriggerRate(env, source, sourceAPS, spellCount, output, breakdown, false, true)
isn't
trigRate = calcActualTriggerRate(env, source, sourceAPS, spellCount, env.minion.output, env.minion.breakdown, false, true)?
That should work and eliminate the need for the "ugly hack".
src/Modules/CalcPerform.lua
Outdated
| local sourceHitChance = GlobalCache.cachedData["CACHE"][uuid].HitChance | ||
| trigRate = trigRate * sourceHitChance / 100 | ||
| if breakdown then | ||
| breakdown.Speed = { |
There was a problem hiding this comment.
use env.minion.breakdown instead of breakdown
src/Modules/CalcPerform.lua
Outdated
| trigRate = trigRate * sourceHitChance / 100 | ||
| if breakdown then | ||
| breakdown.Speed = { | ||
| s_format("%.2fs ^8(adjusted trigger rate)", output.ServerTriggerRate), |
There was a problem hiding this comment.
Use env.minion.output instead of output
src/Modules/CalcPerform.lua
Outdated
| end | ||
|
|
||
| breakdown = breakdownBak | ||
| output = outputBak |
There was a problem hiding this comment.
unnecessary if we do it the other way
|
Indeed, good point. Thank you for the suggestion! |
Nostrademous
approved these changes
Feb 11, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Summon Holy Relic's Nova skill is triggered but wasn't treated as such by PoB.
Could be further improved by refactoring to use an actor instead of a
minionBoolean like other parts of the codebase.Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pastebin.com/6JtUMH0p (credit to https://www.pathofexile.com/forum/view-thread/2717739)
Before & after screenshot:
https://imgur.com/a/v4l0Tzs