Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect minion cast speed from Ancient Skull #4023

Merged

Conversation

Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Feb 1, 2022

Fixes #3998.

Description of the problem being solved:

Ancient Skull gives minion cast speed and attack speed. It should only give attack speed. This PR fixes that bug by restricting the relevant modifier with ModFlag.Attack.

Link to a build that showcases this PR:

https://pastebin.com/Y4Gk5Xzk

@Lothrik Lothrik added the bug Something isn't working label Feb 1, 2022
@LocalIdentity LocalIdentity merged commit ec07c55 into PathOfBuildingCommunity:dev Feb 1, 2022
@Lothrik Lothrik deleted the fix-ancient-skull branch February 2, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ancient Skull increasing minion cast speed by 50% (it should only increased Attack speed and damage)
2 participants