Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siege Unique Changes #3974

Merged
merged 14 commits into from
Feb 3, 2022

Conversation

ifnjeff
Copy link
Contributor

@ifnjeff ifnjeff commented Jan 28, 2022

I've done a sweep through all changed items in the item tab to check for correctness, I'm not aware of a better way to prove correctness as the new unique text doesn't affect existing builds.

Note that this change only includes the textual changes to the uniques, I haven't implemented any new/changed modifiers. During my sweep I intendified and added support for the following new/changed mods:

  • "Nearby Enemies are Scorched" - Legacy of Fury
  • "Trigger a Socketed Spell when you Attack with this Weapon, with a 0.25 second Cooldown" - The Poet's Pen, Cospri's Malice, Mjolner
  • "With at least 40 Intelligence in Radius, Blight has 30% reduced Cast Speed" - Spreading Rot
  • "Dread Banner grants an additional +(2-4) to maximum Fortification when placing the Banner" - Perfidy
  • "This Weapon's Critical Strike Chance is 100%" - Trypanon

The following mods are unsupported but I assume come for free with the GGPK:

  • "Trigger Level 15 Manifest Dancing Dervishes on Rampage" - The Dancing Dervish, The Dancing Duo
  • "Socketed Gems are Supported by Level 25 Divine Blessing" - March of the Legion

The following mods are also unsupported but I don't think they would need to be:

  • "Lose (40-80) Mana when you use a Skill" - Voidbringer
  • "Lose 40 Mana when you use a Skill" - Apep's Rage

When updating the quiver base types, I increased the level of requirement of quivers whose old requirement was lower than their new base's requirement, but I didn't lower the requirement for the opposite case. We may need to check the new level requirements on league start.

In addition, quivers which are on new base types currently can't be found in the item tab because they get rejected as invalid items, I assume this will resolve itself once we get the ggpk data in.

@Nostrademous Nostrademous added the enhancement New feature, calculation, or mod label Jan 28, 2022
@ifnjeff ifnjeff force-pushed the SiegeUniqueChanges branch from 1a5547a to ec268de Compare January 30, 2022 03:47
@ifnjeff ifnjeff force-pushed the SiegeUniqueChanges branch from 35df584 to f4ac14f Compare February 1, 2022 08:34
@LocalIdentity LocalIdentity merged commit b907804 into PathOfBuildingCommunity:dev Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants