Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Passive Tree Management Titles #3962

Merged

Conversation

pHiney
Copy link
Contributor

@pHiney pHiney commented Jan 27, 2022

Fixes #3961.

Description of the problem being solved:

When Managing Passive Trees (Copy, Rename, New, Delete). The title of the popups are sometimes incorrect.

Steps taken to verify a working solution:

  • on Tree tab, choose "Manage Trees ..."
  • Choose a Passive Tree and select Copy, Rename, New, and Delete and confirm the titles match the action
  • Changed "Delete Spec" to "Delete Tree" as Spec is an internal name.

The alternative was to set Copy, Rename, and New to "Set Name" for consistency.

Link to a build that showcases this PR:

N/A

Before screenshot:

After screenshot:

image
image
image
image

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jan 29, 2022
@LocalIdentity LocalIdentity merged commit 165ed96 into PathOfBuildingCommunity:dev Jan 29, 2022
@pHiney pHiney deleted the fixPassiveTreesTitle branch August 30, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When managing passive trees, if you click "copy" the box is called "rename"
2 participants