Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skills from items getting +1 level from Awakened gems #3960

Merged
merged 3 commits into from
Jan 28, 2022

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Jan 27, 2022

Fixes #3957 .

Description of the problem being solved:

Envy linked to Awakened Generosity would revert to the level 1 version when Generosity was leveled to 5

Steps taken to verify a working solution:

  • Used build in issue, verified Envy no longer loses damage

Link to a build that showcases this PR:

eNrtW21z2rgW_lx-hYaZ3tk7twFsY5Jwk90hhCTMkJSFpHvvp45iBGgjW9SWSdid_vd7JNlgwIBwu71ftp3ZGvs5LzpvOkf2Xvzy5jM0J2FEeXBZtiq1MiKBx0c0mFyWnx5vTs7Kv_xcuuhjMf04voopk09-Lr27UNeIkTlhQFdGAocTIj6lnJzPwGmGAzElPLjHv_Pwlo8uyw88IGX0jIMRFekvj-EoesA-uSwPPSAuIxx5JBi1V_c10Mc0GHLvhYjbkMczJXZOyes9HwGme9__OHjMCKVBVijo_O6iz_CChEOBBYrgP5fllifonAAU5PaoTwVwxCwGdk6jXN1BA-bCE3KXAdd2YYczQkZLmFWx3V3Ifkg64zFR-rRDKtpTHHjksIRjsfcxE3TGKAkzau3U6pELzK77w8O8NZIb2OQ3KqZXDOxixFeiu5OACmIM73Ma8eAorY3Abe4_08BQ73sc4DaPDOzRo2NihuwMzXADCE8zpNSyT0JIN2Gu7FEEiYQh8Tik9DEyjiHJrKOYsAKUnWERggKChmKVq_Zup5MvWeDp6S7gNXkzY5cFnp7vAnYDYcYuC7Rcd7d6cy7UNmDiuiWqsa8Ge02J7QaeGdOnICQRCeeZ0t0wJEg8vFpobS_hgEyI4Up7hHjTW9gCB1gQs4xY-cXdaxyJNTKOBOYYxxC_aZu9ZBuWqdT3gY-0zW84NFC-E5BwshhOKWGZLfyAKbNERibNEhhGQ5bkyJV35jjK5pbV2L8aDTeLDQJ7OhCMiGk70g_577LhYceRtUKfx6tC555ae9eg4UZL6E8XEfWgIcA-7KADMoq9tUp0vtuuaet2z-fEhyBXjR80ppkIPt8ZOVcMulrT5QNnxo6iaAmBvZdrPpqQo4QcTzGMZzPIdhkzpnQ3NARLRzSzEZ40DNAfoQtv45lJ1yYTy1TACm0soEcnUxHAWGQuZYPEfC1TzKMjFrOCG4u4iZlZw9_nr8ByKse-aDU1maDv8dthgpuQBH8sNvnXjOBGAjrBKA5ljBrL2KQwEmMwYeqH2xOmLkOrWn3WcCt23XVsx25Y7i7inSPnFnJruLMdB2ZBt9Fw67XTxvl-upxRbwuZO-oZSskf_AyJt0dA-7RRcQ7A1-3tunalsU-7PCH1RqVWMzVglrRu1Sv1na7KGz0Nha11ydapbe8D5ncgudD9nccWSW43ZYQ21Mm0K7qoqqMredX1ZzwU6mYbMy9SjLvBLBYoUOdO0ZS_akFl9Mw5Izi4LIswJokSa9gXytjnIPaf5dGK_lceUW0jfRp5n5_j8VgeXJVB_VCdtnVubjrtx-6nTkIyJKr7QB5nDM8iMrosjzGLgILC5VCKG0LP5Qkj_B0VSXyboKFD9kIKRdEELEuBkcqqMpkg5UGVERA8iBkxN9jjYkZkzESmNkvaGBO0KnRGSF04zBaoKqCZG4iHF0bIZXoYoTuMtCiTTa2Z1e4hvHU_bIaH9jSkz7EwjDZVz4z0kBOw0QKzpckwO8yAyahipEQymZlgkw7QLChhUDB22zUZEwh3w7RX5eQRv5AgKaxpEb1QuRahCKrrLfGjqwXsWzfSvBs7mY8FBCLxe_I1wiOXfRX2BAl7-rVCImyNTVJ_0YiMcczk_V9jzKhYyPqeuZuwsOGmrOJyMtFsZAmIwDW9nn7SYiLhIGWkQvX65TLUawfdxanfapHAGIwQeCwekW6Q9MxLhRl-lrLLaCLfU7R5HMD-FFAm363gZybtqBexwVpuF1LwuwtQJcHeMv6Mmb0yhgQmm19GHWvtSXJzgCk4bfgCu4SQWxhb2STL3ErVURy6oN0njGGW830pQxNH25KV0C_adF1Vf5TtYdXEl7_vicAjLHC1K8CwVWndqiKEq1wBXzKO3DCUp20IAuUWKud6rSTSTFC-mlsW0GGttTjoYet7eDhiXHaLBM9AS-s7e9zYn8voh0rHI7DxDm9mbkqnDYnY6WQF7eNQI_a5fJl5WfG5vk4WnOfsHarLpckAINAl4hlJSu0-ayY2qx9tsj6Lo7_AFGtsTUO_9SqrLhmhjFl-QGxHsJl58lUrLKlpNx_IK5KXH9BTEBGBWn4MabYjBdKHBRIgfcnsHvJZJ5gv8l10pH0Vox9fLIrb5nAJaIXet0ZvUruznIwDVtIczNsfGL1W80k21iNghK5DgiGI27GQXxz8FSU89dL_I4L_3lr-3lq-79aSXKlO_zEkBGGdDYreSlpn-JH9jkfqXZO5E0F7v0jGQ5mmAR_Jdtw9O3OcMhLALvMNkdVIPg_S5NoBnZFM3AdJl7jkadBTF--mQsyiZrX6-vpamWEx5WPyRhmpeNyvzoANaHmiTHoiBVVb8Odq0lJ_FKNqyulCf2cUpSuH1aiFy-XKiwcO46p8Jm-mP5QxPlHYFSOCQ286FKFc4R-c-_9Vq5fjxh3B4h7PlkEjnyazipOMKgKLawoWCtUsljpLAv-zPMRSrk8Mn82nOCL60wJdr9TtzEQjoWiOQ4ql4-t6kEvq1wBui0UTPT10f33qlDbqYykpj6UewZOYNNEV3PWmpU-aWRP1Q4LsSqNSW7_lVGrbt6w1WDsOYamipE-zQObySX0pNRnRmsiulRLfNNHtCfwtKesNyJcmapyXuv6MUY_Kp3bpz2SlTeurdfZe7hmgM8wDqOV5MUyaCzTAggaTFdD-4Hyof63XsmCdxrtprA9A9fU2hOtI1wBkuUgWYKTyZIWsr6PsfJTm9ycgJ6RZq7hfdT2KYLgFNX5yaif12j-zCupBPCtmJ3GjdnKWS5zCpnhO0L_s8_dIcKTeHyF92iCPwdZ0XHLWp1mwFOJTEiG4vKNiBZUGXePeAOt66lhNysinTgnUSRVy3yM-TjSFooLkERDCE9iHI5EwgJUkLFT63vPRQJoAKUPIt6-ujnU3LeM7EemRv6quq6SRj-z1RBm0Bp1S2gSXsj1wqcNGJNT32yEeQ1A3kUzjEsT_mL41kfwmcc-PYTw-8CPjYh1UMpRaEKFPzyS0VvmSTZdsqpxlU8Uq3YFZLaShpSRKezmxvG2YZTWxtf2c3GryiTP2D6hI0b8hYEIomJ7gYemOs4WMMhpAU8VK-risidxTK7m-ghhNPhuBOi4V1Yd1SJ_WwQ2oB9nzu02CWuX8_LS-LFo9MoG42ixHp2bVyN7UN7coXZ0s_2bs7bhZe9eypamxVm30uhEOVECvlpqpUdn0_smq1U4sdz2nd_JwQVQoP2sAkI_fqB_7SB6TluRhMMJIvaVF-vUmGvMQyRKvEmuBFjxGUyrQKxVTgMojevmtBIJdjr6QrHrdIJBceDCn6vxwf77ZW_k2hIY7eVWy6rphM1LNT_pCJQO64qMFSr8KSXHONi4dQVNIKjnZP_fsndltMk-94SueodbzIoqkQVQkIHclqJYWnRzSTTLbjGzLIBsW4ZC_xRTKW8sBpa4IE0eS3MCu_oIcI5XsPJWcYuY1M4L9ncjqxZRsFJPWKG5N64CD8-LpgAfuCPOJOFZQTiQ1isg5EH7Q083lJx_HM3aKZ5FVRF69WCxYxSKvftg9JoY9lm1eeBVcuFHdcQvoU6AGOofELPetI92Xb-VC8eUWITJKSRNHFFqnW9isdgG_N4plklMsfJ3jo6xevOwXiGmrsPEdk4Com4AKqP0NzY-hJ4t7oVEgKou74RvCxbQkS1rDrDGHFrDcgAYTs07g6EKx07wFy4W5P7dGHIPlOAZ2soq7oV7YWm4R55jkS_EgP6DSriGymkyR6phYnc6qzwp5MKaTrS8AYdJc_3x6--PCi2pKe1Hd_L9v_wdD5Qkt

@Wires77 Wires77 added the bug Something isn't working label Jan 27, 2022
@Wires77
Copy link
Member Author

Wires77 commented Jan 28, 2022

Note: This change may not be needed, since Awakened Generosity shouldn't affect skills from items anyway, and those are the only ones without contiguous levels

Copy link
Member

@ppoelzl ppoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for the regression test.

@Wires77 Wires77 changed the title Fix Envy losing damage when adding a level Fix skills from items getting +1 level from Awakened gems Jan 28, 2022
@Wires77 Wires77 merged commit c230669 into PathOfBuildingCommunity:dev Jan 28, 2022
@Wires77 Wires77 deleted the envy_level branch January 28, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awakened Generosity innacurate with level 25 Envy Aura
2 participants