Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Bleed/Ignite Ailment calculation to use weighted average #3927

Merged
merged 22 commits into from
Feb 4, 2022
Merged

Updated Bleed/Ignite Ailment calculation to use weighted average #3927

merged 22 commits into from
Feb 4, 2022

Conversation

Nostrademous
Copy link
Contributor

@Nostrademous Nostrademous added the technical Hidden from release notes label Jan 21, 2022
@LocalIdentity LocalIdentity added enhancement New feature, calculation, or mod and removed technical Hidden from release notes labels Jan 25, 2022
@Nostrademous Nostrademous changed the title fix: updated Bleed Ailment calculation to use Weighted Avg fix: updated Bleed/Ignite Ailment calculation to use Weighted Avg Jan 25, 2022
@Nostrademous
Copy link
Contributor Author

Fixes #3970

Wires77
Wires77 requested changes Feb 1, 2022
View reviewed changes
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, I just had a few comments. Not fully done testing it yet, and it's probably going to merge after #3271 which may cause some conflicts.

@Nostrademous Nostrademous requested a review from Wires77 February 1, 2022 04:38
@Wires77 Wires77 changed the title fix: updated Bleed/Ignite Ailment calculation to use Weighted Avg Updated Bleed/Ignite Ailment calculation to use weighted average Feb 4, 2022
@Wires77 Wires77 merged commit d4c323d into PathOfBuildingCommunity:dev Feb 4, 2022
@Nostrademous Nostrademous deleted the FixStackLimitedAilmentCalcs branch February 4, 2022 16:03
@Lothrik Lothrik mentioned this pull request Jun 24, 2022
Closed
@QuickStick123 QuickStick123 mentioned this pull request Jul 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wires77 Wires77 Wires77 approved these changes

Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nostrademous @Wires77 @LocalIdentity