Fix incorrect reservation on some legacy builds #3909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wires77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3211.
I checked a few of my own builds and didn't notice any inconsistencies with mana or life reservation values before and after this change, I'd appreciate additional testing on that front though.
Description of the problem being solved:
Legacy builds with 100% reduced mana reservation end up reserving very small (but non-zero) values. I fixed this by just completely rewriting the
reservedFlatandreservedPercentformulas to match current behaviour in PoE and fix this edge case. As a bonus the formula is also significantly less confusing to look at.Link to a build that showcases this PR:
https://pastebin.com/qVpv8y1b
Before screenshot:
After screenshot: