Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add starter race uniques #3874

Merged
merged 4 commits into from
Jan 21, 2022
Merged

Conversation

pHiney
Copy link
Contributor

@pHiney pHiney commented Jan 8, 2022

Fixes missing race uniques, #3843.

Description of the problem being solved:

QOL: for adding racing uniques

Steps taken to verify a working solution:

  • open a build or a new one
  • go to items
  • choose 'Endless Races' from the league dropdown

image

Build from the reddit post
https://pastebin.com/33KXG5WE

@Nostrademous Nostrademous added the enhancement New feature, calculation, or mod label Jan 9, 2022
@@ -541,6 +541,7 @@ data.uniques = { }
for _, type in pairs(itemTypes) do
data.uniques[type] = LoadModule("Data/Uniques/"..type)
end
data.uniques['race'] = LoadModule("Data/Uniques/race")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are tied to special events I would suggest moving the file to "Data/Uniques/Special/Races.lua" and loading from there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved

@Lothrik
Copy link
Contributor

Lothrik commented Jan 10, 2022

"Race Event" might be a more appropriate than category "Endless Races" -- as these uniques aren't available in Endless Heist, they've only shown up in Descent: Champions and Endless Delve IIRC.

Edit: After double checking this pull request only includes Endless Delve uniques, it's missing some from Descent: Champions (Chains of Time, Tear of Entropy).

The name of Thunder of the Dawn is incorrect, Rust of Winter has way too much cold damage, the Freeze/Shock/Ignite text on Splinter of the Moon doesn't match GGG's formatting, and there are various other formatting/capitalization errors.

@pHiney
Copy link
Contributor Author

pHiney commented Jan 10, 2022

yep 'race event' is good. Though it thought i was using them for Endless Heist ?

pH

@Lothrik
Copy link
Contributor

Lothrik commented Jan 10, 2022

yep 'race event' is good. Though it thought i was using them for Endless Heist ?

Huh, looks like you're right. It shows up on some characters on poe.ninja anyway, I guess I just didn't see it mentioned anywhere.

@Nostrademous
Copy link
Contributor

Nostrademous commented Jan 10, 2022

Actually, needs some fixes still for precision / naming.

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared the uniques to the official ones here and made some corrections. https://www.pathofexile.com/forum/view-thread/2998539

I'm not going to be picky about capitalization differences, because GGG's font doesn't let me know which letters are really capitalized easily, but more importantly they're not consistent with other uniques anyway

@Wires77 Wires77 changed the title Add race.lua for endless race uniques Add starter race uniques Jan 21, 2022
@Wires77 Wires77 merged commit be7af1c into PathOfBuildingCommunity:dev Jan 21, 2022
@pHiney pHiney deleted the Add_Race_Uniques branch August 30, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants