Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Bone Offering quality effect #3860

Merged

Conversation

Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Jan 1, 2022

Description of the problem being solved:

Bone Offering default quality was missing from the statMap and did literally nothing (both for minions, and players with Mistress of Sacrifice).

Steps taken to verify a working solution:

  • Check cast speed of minions (and player with Mistress of Sacrifice) with 20/20 Bone Offering active.
  • Apply changes from this PR.
  • Check cast speed of minions (and player with Mistress of Sacrifice) with 20/20 Bone Offering active.

Link to a build that showcases this PR:

https://pastebin.com/m5YRrgJk

Before screenshot:


After screenshot:


Bone Offering default quality was missing from the statMap and did literally nothing (both for minions, and players with Mistress of Sacrifice). This fixes that issue.
Copy link
Member

@ppoelzl ppoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Nostrademous Nostrademous added the bug Something isn't working label Jan 3, 2022
@LocalIdentity LocalIdentity merged commit d16a74f into PathOfBuildingCommunity:dev Jan 3, 2022
@Lothrik Lothrik deleted the fix-bone-offering-quality branch January 7, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants