Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Projectile Attack Mod Parsing #3851

Conversation

Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Dec 28, 2021

Description of the problem being solved:

Some skills are tagged ProjectileAttack (and Attack) but not Projectile. This generally means the skill deals projectile attack damage, but does not actually fire a projectile that can collide with terrain (e.g. Rain of Arrows, Storm Rain, Blast Rain, Toxic Rain, Artillery Ballista). In order for nodes like Lethality to correctly match these skills (while still matching all normal projectile attacks) we need to check the ProjectileAttack tag explicitly.

Steps taken to verify a working solution:

  • Check DPS of Storm Rain with Lethality allocated in 2.13.0
  • Update ModParser.lua and rebuild ModCache.lua
  • Check DPS of Storm Rain with Lethality allocated again

Link to a build that showcases this PR:

https://pastebin.com/ZeCpW2CU

Before screenshot:

After screenshot:

Some skills are tagged ProjectileAttack (and Attack) but not Projectile. This generally means the skill deals projectile attack damage, but does not actually fire a projectile that can collide with terrain (e.g. Rain of Arrows, Storm Rain, Blast Rain, Toxic Rain, Artillery Ballista). In order for nodes like Lethality to correctly match these skills (while still matching all normal projectile attacks) we need to check the ProjectileAttack tag explicitly.
@Lothrik
Copy link
Contributor Author

Lothrik commented Dec 28, 2021

Assuming #3852 is merged before this, ProjectileAttack needs to be replaced with RangedAttack.

@Nostrademous Nostrademous added the bug Something isn't working label Dec 29, 2021
@LocalIdentity LocalIdentity merged commit 8606ee7 into PathOfBuildingCommunity:dev Jan 3, 2022
@Lothrik Lothrik deleted the fix-projectile-attack-parsing branch January 7, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants