Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new max res range for Brass Dome #3739

Merged
merged 2 commits into from
Nov 24, 2021

Conversation

olop4444
Copy link
Contributor

@olop4444 olop4444 commented Nov 7, 2021

Description of the problem being solved:

PoB currently lists Brass Dome's max resistance roll as being from 1% to 2%, when it is actually 1-5% in-game.
image

Before screenshot:

image

After screenshot:

image

Copy link
Member

@ppoelzl ppoelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Lothrik
Copy link
Contributor

Lothrik commented Nov 17, 2021

The way this modifier is currently written (both before and after this commit) incorrectly affects maximum chaos resistance. I believe this error was initially caused by an outdated description given in the 3.16 patch notes.

Suggest changing to +(1-5)% to all maximum Elemental Resistances to match in-game behaviour.

@olop4444
Copy link
Contributor Author

The way this modifier is currently written (both before and after this commit) incorrectly affects maximum chaos resistance. I believe this error was initially caused by an outdated description given in the 3.16 patch notes.

Suggest changing to +(1-5)% to all maximum Elemental Resistances to match in-game behaviour.

Done.

@LocalIdentity LocalIdentity added the bug Something isn't working label Nov 24, 2021
@LocalIdentity LocalIdentity merged commit 9aa98cb into PathOfBuildingCommunity:dev Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants