Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bleed damage against poisoned enemy mastery #3700

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Nov 2, 2021

Fixes #3699

Description of the problem being solved:

  • Parsing for this mastery creates a mod for "BleedDamage" which is not correct. Changed to "Damage" with KeywordFlag.Bleed

Steps taken to verify a working solution:

  • Allocate mastery, check bleed DPS before and after checking enemy is poisoned

Link to a build that showcases this PR:

eNq9Wltz2sgSfg6_QkXVvmFAFwS47N3CGCeuMg4LTnzOU2osNTDxSEOkEZhs7X_fnpEAgbkMyp5DqhxJfH3v6ekecfXHW8CMOUQx5eF12azWywaEHvdpOLkuf3m6u2iV__i9dDUgYvp5fJNQJr_5vfThSl0bDObArsstJBMkmoD4umJlf8NnMxKKKfCwT77z6CP3r8uPPISy8UJCn4rVncdIHD-SAK7LtwkwGouyQWIPQr-7-SaFBoSGI-69gvgY8WSGGpeNOYVFn_uIue8PPg-fcmJpmBeLan-4GjCyhGgkiDBi_HNd7qD1ZAK3JMC_yI2wBFnZzapr23XLalltxzbLtf3EoxmAvyZC97X-n8hBBL3xGDxB59CNqOhOSehtbGhUm4co96DNqtuwj-H7CRN0xihEOZrGIYpP7wRY7UPYJy4Iux2M1tCWWbVaTdtq26bZaJr_Gzou1nT1Q8gbhrHIS3Ab9arltNuHmackO9lkNUxJ1moc9NczFdN30po2ethu2vW6MugY7f0kpAIKOEMSDziNefgLnjzPRV0evNCwkKkr0s58cq6ufRKSLo83UT8Yiwc6hi3kwfzojfRwQ8wGPaTUcgARVj-hRyCVPYtgJKKc1w9qDD_yQNM5yO8W3jZr_Bi_PNA8vBLuQ5ETe4RfHnhEuzkXuCPpOXIjuO4cK9DepUTfh54e2y9hBDFE83xdPyJgmyQLbo7yqKwhTEDT2gcAb_oRt9QhEaCXmpvFY5lH_SPBWv6RwD3-OcJ_m-IM90jCbfe0q0elnOmgZxL5GjUjhGiyHE0pMA20cmaeRMupeQLNhMiTnGl3b07i_BIz3ePWpHC97ADcE5HAh51u4l-kGET8u2yi2HlknSjgSaQZwRSsZfJguoyph9uq6iGG4CeeXgFb94J9PocA14TqJLE13gTmcNOCTbWu4ciWsbMoOkIQ7_WW-xM4S8j5FKNkNsPKIPNLl-6ORujlmOb2zgtXA_0ZB4cumZ0W0OVyEeoK2KC1BTzQyVSEOJjpS9kh0bdlSnh8hjEbuLaIu4RtNfWHA_5Kt5GCvDC4NOpvpm-3PNs_PDjxBSozlRNrrLEgc-g-2fQwB3uduwjCn0tt_ltwLQG90E8imd3aMnYp3ou5qqmRXl7dBzMeCfWwS5gXK5b34SwRRqiG8YDG3reXZDyWc3cZRUTqvKB3d9frPt1_7WVa5EliGaxvYRK8yPkx_X9TkEagapzhccbILAYc2ceExcib-lmgR1jXPaGFx9kzG8B00LhrexFFJ-qA5dSopbIa4nWQcrTWAmJUCAN9hz0tZyAzINb1WVYwddBqUtVCpqOlnoFqhNULA3hkqYVctzJa6B6DDmVy79TzWh8XQrrt6uFxI4zoSyI0s02NJFp6yNZcy8B886m5OvSAWTukpUTWL-pgs71GLymxJdEO2y2MAdNdc9mrcvJEXiHMiuWqMF6ptRYbMVbMjxDEN0vcke6ke3fOObYAuFdFCfL2YUwSJp__mRBGxVKW8NzTh_R81cKH8ZQvZHeTspGLO0anPzyk33SYyDhIGSvdU8ukgurktKO6Q3Wv1FfHpzT0WOLjLJvtu2u7GXmRssvGRB61dnkS4j4SUiZPiOVG66-M2GEtuUrBH65QlQz7kfEXwqw1b7Ub9GmIHt9RJ_dN9rDzRuMeWgYj7IwoRLc8oCERuONgwBfl1Rm0VS9vCTNX6imO96p2J_jtCFfg6x4VlPQfqQ8VOg0Cmg-BvO-DID4RpHYv0MM16eaaIsSrbc4_cqHccZWXehElyV1RTgYrtYw9emEhT4KAYwYNsDQLEgdZsqaCVR6m6ScvnyIAg6RxUIzNLP54kz9Pl8bUZdRiAdEyq17X5b9cu2nWK2a94bh_o364s-NTy7XaTsWtt1rNimO1TbPiNO1Wu2LaVtOupCROveU2K5ZtttuVRr3dcitu0zErltNyGwh3y4ZA1XJvBnA-TA_9pSpOliw9H0PsP0qxtfTJl-GDuvgwFWIWX9Zqi8WiOiNiysfwhtNa1eNBbYZs0OIL5bYLKajWwc_N5M9O1yJW04cwbL76_Xbo2LOL78-zFvn63Jt2_EWnM3pdXjw610pYbSXtKn2_EK88jd5TjpbulRePHKu3_E4-XN0o53-lsDBiwHZiisGUK-cn58F_sUFuOo2q3bRWn3TJfgIi-mS2XhMSnK13N1vuuHvfUgxQpCrVKokk8D_yoKPquBiR7JPWJZWcWRbI6xGk6ZbEgBWOh_4zkBlmvHycqxESqgpdtnSHBLuS5aUx7Ax7pUc0SwJKvZ88WAowOm9Q6kZkjPG6NKROpUEEY_p2acj3LEduRtgyvrv5C_vSCVzWq42_c2fn1jY4K26XhlUvZQFC7S7W_0rKc0P4cWm4VglbJUY9KjH1Ujp8xsaUzMGwGr8ZnupzDMENj6BfDCUVy0nJdn-T5TACgvXfSPUwFlRMNxCZEtIX6cpifNXepm41ZD0Vab1YtbZZFI5EIO_4fTxHCzIzOi_LOCbMSI03GhtBWc-_l3SXzNIje2fFFuqGcxEXVGifLSeUugEmziS5w-LyathaKln7VLKLuVfPCda_ROYUU9ItJs0t7k3zRID35dOJCHwC7NLFuYL2ZJJbRM6J9MMGZC6H8vMZ28VXkVlEnlMsF8ximeecDo-OY89luy-9ChquVXcaBfQpUAPtU2L8pZEOZWeGb7-XC-VXowiR1pLUCUQhOxuF3WoViLtbbCXZxdLXPj_LnOJlv0BOm4Wdb-skhKMDKqD2LzQ_mpEsHgW3QFYWD8MvpItuSZa0mqtGH1rAc0OcB_Q6gbMLxUH3FiwX-vEsYo6t4SezeBicwt5qFLFGZ70UT_ITKnWChO3Z29KZE0dGdRKhZnz1coaHYzp596pFDplUHmb2QgiWq9G1bLxwzoCE2TFC7QRdenAvf5Fxii5Y_zAwpfmcMti85anvE5bEggd97seb90ero9XMrKva7s9O_wEXQk57

Before screenshot:

Baseline
image
Poisoned
image
image

After screenshot:

Poisoned
image
image

@Peechey Peechey changed the title Fix increased bleed damage against poisoned enemy mastery Fix bleed damage against poisoned enemy mastery Nov 2, 2021
@LocalIdentity LocalIdentity added the bug Something isn't working label Nov 2, 2021
@LocalIdentity LocalIdentity merged commit c9fb516 into PathOfBuildingCommunity:dev Nov 24, 2021
@Peechey Peechey deleted the fix_bleed_dmg_against_poisoned branch January 25, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants