Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically generate Watcher's Eye #2305

Merged
merged 8 commits into from
Apr 4, 2021

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Mar 4, 2021

  • 1. Generate variant names for the dropdown
  • 2. Support legacy mods
  • 3. Add wording changes to ModParser.lua (e.g. "increased cooldown recovery speed of Movement Skills" became "increased Cooldown Recovery Rate of Movement Skills used" at some point)

There are a few mods that are excluded, which may be legacy, but I can't search them on the trade site, so I'm not sure.

reduced Reflected Cold Damage taken while affected by Purity of Ice
reduced Reflected Lightning Damage taken while affected by Purity of Lightning
skill effect duration while affected by Malevolence

@Wires77 Wires77 added enhancement New feature, calculation, or mod wip Unfinished and commited for discussion labels Mar 4, 2021
@Wires77
Copy link
Member Author

Wires77 commented Mar 16, 2021

I ended up using the same labels that GGG uses for their Ids, but sometimes they can get too long for the box. Let me know if I should do some common substitutions.

Added all the legacy mods, however they currently don't show up next to the current form of the mod, and the label doesn't match the auto-generated label either. Since this is a low-priority issue, I may properly fix it before removing the WIP label.

@Wires77
Copy link
Member Author

Wires77 commented Mar 17, 2021

This is ready for review.

@Wires77 Wires77 removed the wip Unfinished and commited for discussion label Mar 17, 2021
@Wires77 Wires77 merged commit ea953e5 into PathOfBuildingCommunity:dev Apr 4, 2021
@Wires77 Wires77 deleted the generated-watchers-eye branch April 4, 2021 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants