Support "enemies taunted by your warcries take x% increased damage" #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not leverage https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/master/Modules/ConfigOptions.lua#L915 along with the "taunted" config option? |
|
Good idea, thanks @Nostrademous. |
[v2] Rely on both Condition:Taunted and Condition:UsedWarcryRecently
|
Tested by regenerating ModCache, selecting the 4 combinations of Condition:Taunted and Condition:UsedWarcryRecently in sequence and checking the notable "Natural Authority" output every step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[v2] Rely on both Condition:Taunted and Condition:UsedWarcryRecently
Adding a config entry "is the enemy taunted by your warcries" felt a bit overkill.Another option was to check for the presence of any warcry before enabling the mod, but that too felt overkill.I decided to simply use the taunted config option already available instead.