Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build inoperable if you disable all active skills with Tawhoa's Felling equipped. #8478

Closed
2 tasks done
umn-anon opened this issue Feb 14, 2025 · 7 comments · Fixed by #8507
Closed
2 tasks done

Build inoperable if you disable all active skills with Tawhoa's Felling equipped. #8478

umn-anon opened this issue Feb 14, 2025 · 7 comments · Fixed by #8507
Labels
bug Something isn't working

Comments

@umn-anon
Copy link

umn-anon commented Feb 14, 2025

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

Should not be getting spammed with error messages and unable to open a build after closing POB

How does Path of Building behave?

Gives error message every time I click on build. Before closing it, whenever I was messing with the active skills it would throw the same error.

How to reproduce the issue

Create new build.
Set skill to any melee skill compatible with two hand maces (ie smite).
Select Tawhoa's Felling as the weapon.
Uncheck the active melee skill and save the build and close.

Now the build will always throw an error message when you try to open it, and it will not open. The error only seems to happen when the active melee skill is above Tawhoa's Chosen in the "Socket Groups" tab.

You could also recreate it by trying to import my build string, though it just crashes and fails to load so maybe only useful for testing a fix.

PoB for PoE1 build code

https://pobb.in/IjlXE2-NbvaG

Screenshots

Image

@umn-anon umn-anon added the bug Something isn't working label Feb 14, 2025
@umn-anon umn-anon changed the title POB inoperable from repeated error message in new build Build inoperable if you disable all active skills with Tawhoa's Felling equipped. Feb 14, 2025
@umn-anon
Copy link
Author

umn-anon commented Feb 14, 2025

Edit: Figured out how to make a PR, ignore

--I got a local fix working but all my push requests seem to be rejected.--

It seemed like there were two places this error could manifest, so I changed CalcActiveSkill.lua by adding at line 156

   if not skill.activeEffect.srcInstance then
           return skill, env
   end

and changing CalcMirages.lua at line 37:

           if not newSkill.activeEffect.srcInstance then
                   config.mirageSkillNotFoundFunc(env, config)
                   return not config.calcMainSkillOffence
           end

The diff looks like this:

Image

There's probably a more fundamental issue going on since this doesn't seem to happen with other mirage skills like Saviour's clones, so I would guess some difference exists between those two that is causing this issue specifically for Tawhoa. But this was the quickest solution I found, knowing nothing about Lua or POB, and I don't think asserting that these fields should exist is too harmful.

@Paliak
Copy link
Contributor

Paliak commented Feb 14, 2025

@umn-anon You need to push to your own fork. You won't be able to push directly to this repo. Triggers are my responsibility. I'll take a look.

@umn-anon
Copy link
Author

@umn-anon You need to push to your own fork. You won't be able to push directly to this repo. Triggers are my responsibility. I'll take a look.

I tried pushing my own fork and that also seemed to get rejected. I'll tamper with it some more.

@Paliak
Copy link
Contributor

Paliak commented Feb 14, 2025

@umn-anon Are you logged in? Are ypu sure you're pushing to the right origin?

@umn-anon
Copy link
Author

umn-anon commented Feb 14, 2025

@umn-anon Are you logged in? Are ypu sure you're pushing to the right origin?

Image

Is this the relevant stuff or should I be looking at another field?

And yeah it prompts me to login every time I push so I would assume it has my credentials.

@Paliak
Copy link
Contributor

Paliak commented Feb 14, 2025

@umn-anon origin is set to this repo so by default it'll push here and not your fork. You need to run git remote set-url origin $YOURFORK. If it's prompting you every time then something is messed up without with creds. It should cache them. Are you using wsl or git bash? Look into auth providers.

@umn-anon
Copy link
Author

@umn-anon origin is set to this repo so by default it'll push here and not your fork. You need to run git remote set-url origin $YOURFORK. If it's prompting you every time then something is messed up without with creds. It should cache them. Are you using wsl or git bash? Look into auth providers.

Using MINGW64 git bash console, I'll look into the auth stuff then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants