Skip to content

Commit

Permalink
Merge branch 'dev'
Browse files Browse the repository at this point in the history
  • Loading branch information
LocalIdentity committed Feb 12, 2025
2 parents 46f9810 + 8b3ec35 commit 988efe8
Show file tree
Hide file tree
Showing 99 changed files with 18,714 additions and 17,399 deletions.
11 changes: 6 additions & 5 deletions .github/ISSUE_TEMPLATE/accuracy_bug_report.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
name: Accuracy bug report
description: Create a bug report to help us fix incorrect wordings
description: Create a bug report to help us fix incorrect wording in Path of Building for PoE1.
labels: ["bug:accuracy"]
body:
- type: markdown
attributes:
value: |
Thank you for reporting an issue.
Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
Thank you for reporting an issue with PoB-**PoE1**.
[Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues)
Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
- type: checkboxes
id: version
attributes:
Expand Down Expand Up @@ -56,9 +57,9 @@ body:
- type: textarea
id: build_code
attributes:
label: Character build code
label: PoB for PoE1 build code
description: Always provide a build code that exhibits the bug you want to report, even if it is not specific to a particular build. This helps us greatly to reproduce bugs faster.
placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a shared build.
placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build.
render: shell
validations:
required: false
Expand Down
11 changes: 6 additions & 5 deletions .github/ISSUE_TEMPLATE/application_bug_report.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
name: Application bug report
description: Create a bug report to help us fix an issue in Path of Building
description: Create a bug report to help us fix an issue in Path of Building for PoE1.
labels: [bug]
body:
- type: markdown
attributes:
value: |
Thank you for reporting an issue.
Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
Thank you for reporting an issue with PoB-**PoE1**.
[Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues).
Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
- type: checkboxes
id: version
attributes:
Expand Down Expand Up @@ -65,9 +66,9 @@ body:
- type: textarea
id: build_code
attributes:
label: Character build code
label: PoB for PoE1 build code
description: Always provide a build code that exhibits the bug you want to report, even if it is not specific to a particular build. This helps us greatly to reproduce bugs faster.
placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a shared build.
placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build.
render: shell
validations:
required: false
Expand Down
11 changes: 6 additions & 5 deletions .github/ISSUE_TEMPLATE/behaviour_bug_report.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
name: Behaviour bug report
description: Create a bug report to help us fix incorrect behaviour or logic
description: Create a bug report to help us fix incorrect behaviour or logic in Path of Building for PoE1.
labels: ["bug:behaviour"]
body:
- type: markdown
attributes:
value: |
Thank you for reporting an issue.
Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
Thank you for reporting an issue with PoB-**PoE1**.
[Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues).
Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
- type: checkboxes
id: version
attributes:
Expand Down Expand Up @@ -71,9 +72,9 @@ body:
- type: textarea
id: build_code
attributes:
label: Character build code
label: PoB for PoE1 build code
description: Always provide a build code that exhibits the bug you want to report, even if it is not specific to a particular build. This helps us greatly to reproduce bugs faster.
placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a shared build.
placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build.
render: shell
validations:
required: true
Expand Down
11 changes: 6 additions & 5 deletions .github/ISSUE_TEMPLATE/calculation_bug_report.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
name: Calculation bug report
description: Create a bug report to help us fix incorrect calculations
description: Create a bug report to help us fix incorrect calculations in Path of Building for PoE1.
labels: ["bug:calculation"]
body:
- type: markdown
attributes:
value: |
Thank you for reporting an issue.
Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
Thank you for reporting an issue with PoB-**PoE1**.
[Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues)
Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
- type: checkboxes
id: version
attributes:
Expand Down Expand Up @@ -71,9 +72,9 @@ body:
- type: textarea
id: build_code
attributes:
label: Character build code
label: PoB for PoE1 build code
description: Always provide a build code that exhibits the bug you want to report, even if it is not specific to a particular build. This helps us greatly to reproduce bugs faster.
placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a shared build.
placeholder: This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build.
render: shell
validations:
required: true
Expand Down
11 changes: 6 additions & 5 deletions .github/ISSUE_TEMPLATE/crash_report.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
name: Crash report
description: Create a crash report to help us fix critical issues
description: Create a crash report to help us fix critical issues in Path of Building for PoE1.
labels: [bug, crash]
body:
- type: markdown
attributes:
value: |
Thank you for reporting a crash or severe graphical issue.
Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
Thank you for reporting a crash or severe graphical issue in PoB-**PoE1**.
[Issues with PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues)
Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
- type: checkboxes
id: version
attributes:
Expand Down Expand Up @@ -70,10 +71,10 @@ body:
- type: textarea
id: build_code
attributes:
label: Character build code
label: PoB for PoE1 build code
description: Provide a build code if the crash/graphical issue is caused by a certain build.
placeholder: |
This can be either a code copied from the "Import/Export Build" tab or a link to a shared build.
This can be either a code copied from the "Import/Export Build" tab or a link to a PoB build.
In the case where Path of Building crashes/doesn't work on startup or when you open a build.
Go to your builds folder (default %userprofile%/Documents/Path of Building/Builds) and copy the problematic build's .xml contents into a pastebin and supply the link.
render: shell
Expand Down
7 changes: 4 additions & 3 deletions .github/ISSUE_TEMPLATE/feature_request.yaml
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
name: Feature request
description: Suggest an idea for this project
description: Suggest an idea for Path of Building for PoE1.
labels: [enhancement]
body:
- type: markdown
attributes:
value: |
Thank you for suggesting a feature.
Please try to fill in as much of the form below as you're able to. Some of the fields marked with an asterisk (*) are required.
Thank you for suggesting a feature for PoB-**PoE1**.
[Feature requests for PoB-PoE2 go here.](https://github.com/PathOfBuildingCommunity/PathOfBuilding-PoE2/issues).
Please try to fill in as much of the form below as you're able to. Fields marked with an asterisk (*) are required.
- type: checkboxes
id: duplicates
attributes:
Expand Down
42 changes: 42 additions & 0 deletions .github/workflows/builddocker.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: Build and publish busted tests docker image
on:
workflow_dispatch:
jobs:
build-and-push-image:
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
steps:
- name: Checkout repository
uses: actions/checkout@v4
- name: Log in to the Container registry
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Generate docker image metadata
uses: docker/metadata-action@v5
id: meta
with:
images: |
ghcr.io/${{ github.repository_owner }}/pathofbuilding-tests
labels: |
org.opencontainers.image.description=A docker image packaged with the correct versions of tools to run PathOfBuilding busted tests. Includes emmylua debugger files. Refer to https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/dev/CONTRIBUTING.md for usage instructions.
org.opencontainers.image.licenses=https://opensource.org/licenses/MIT
tags: |
type=sha
type=raw,value=latest
- name: Build and push Docker image
uses: docker/build-push-action@v5
with:
context: .
push: true
platforms: linux/amd64
cache-from: type=gha
cache-to: type=gha,mode=max
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
2 changes: 1 addition & 1 deletion .github/workflows/installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
ref: 'master'
ssh-key: '${{ secrets.POB_INSTALLER_KEY }}'
- name: Create installer
run: 'python3 make_release.py'
run: 'python3 make_release.py --game-version 1'
- name: Upload artifact
run: >
gh release upload ${{ github.event.release.tag_name }} (Get-ChildItem Dist -File).FullName --clobber -R ${{ github.repository }};
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,12 @@ jobs:
sed -i '1h;1d;$!H;$!d;G' temp_change.md;
sed -i -re 's/\*\*Full Changelog\*\*: (.*)/\[Full Changelog\]\(\1\)\n/' temp_change.md;
sed -i '/## New Contributors/,$d' temp_change.md;
sed -i -re 's/^\*(.*)\sby\s@(.*)\sin\s(.*\/pull\/)(.*)/-\1 [\\#\4](\3\4) ([\2](https:\/\/github.com\/\2))/' temp_change.md;
sed -i -re 's/^\*(.*)\sby\s@(.*)\sin\s(.*\/pull\/)(.*)\r/-\1 [\\#\4](\3\4) ([\2](https:\/\/github.com\/\2))/' temp_change.md;
sed -i 's/\[Quotae/\[Quote_a/' temp_change.md;
sed -i 's/\[learn2draw/\[Lexy/' temp_change.md;
sed -i 's/\[Voronoff/\[Tom Clancy Is Dead/' temp_change.md;
sed -i 's/\[PJacek/\[TPlant/' temp_change.md;
sed -i 's/\[justjuangui/\[trompetin17/' temp_change.md;
cp temp_change.md changelog_temp.txt;
cat CHANGELOG.md | sed '1d' >> temp_change.md;
printf "# Changelog\n\n## [v${{ github.event.inputs.releaseVersion }}](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v${{ github.event.inputs.releaseVersion }}) ($(date +'%Y/%m/%d'))\n\n" | cat - temp_change.md > CHANGELOG.md;
Expand Down
18 changes: 4 additions & 14 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,15 @@ on:
branches: [ dev ]
pull_request:
branches: [ dev ]
workflow_dispatch:
jobs:
run_tests:
runs-on: ubuntu-latest
container: ghcr.io/pathofbuildingcommunity/pathofbuilding-tests:latest
steps:
- name: Checkout
uses: actions/checkout@v2
- name: Install Lua/LuaJIT
uses: leafo/[email protected]
with:
luaVersion: "luajit-2.0.5"
- name: Install LuaRocks
uses: leafo/[email protected]
- name: Install busted
run: luarocks install busted
- name: Install cluacov
run: luarocks install cluacov 0.1.2-1
- name: Install coveralls integration
run: luarocks install luacov-coveralls
uses: actions/checkout@v4
- name: Run tests
run: busted --lua=/home/runner/work/PathOfBuilding/PathOfBuilding/.lua/bin/luajit
run: busted --lua=luajit
- name: Report coverage
run: cd src; luacov-coveralls --repo-token=${{ secrets.github_token }} -e TestData -e Data -e runtime
29 changes: 29 additions & 0 deletions .github/workflows/update-simple-graphic.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Update SimpleGraphic DLLs
on:
repository_dispatch:
types: [update-simple-graphic]
jobs:
update:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
with:
ref: 'dev'
- name: Download DLLs
uses: robinraju/release-downloader@v1
with:
repository: ${{ github.repository_owner }}/PathOfBuilding-SimpleGraphic
tag: ${{ github.event.client_payload.tag }}
fileName: SimpleGraphicDLLs-x64-windows.tar
extract: true
out-file-path: runtime
- name: Create Pull Request
uses: peter-evans/create-pull-request@v5
with:
title: Update to SimpleGraphic ${{ github.event.client_payload.tag }}
branch: simple-graphic-${{ github.event.client_payload.tag }}
body: |
Update DLLs to SimpleGraphic-${{ github.event.client_payload.tag }} from ${{ github.event.client_payload.release_link }}
commit-message: Update DLLs to SimpleGraphic-${{ github.event.client_payload.tag }}

31 changes: 31 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,36 @@
# Changelog

## [v2.50.0](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v2.50.0) (2025/02/12)

[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.49.3...v2.50.0)

<!-- Release notes generated using configuration in .github/release.yml at dev -->

## What's Changed
### New to Path of Building
- Add support for Legacy Of Phrecia Ascendancies [\#8449](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8449), [\#8456](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8456) ([LocalIdentity](https://github.com/LocalIdentity))
- Add unique jewel for each Ascendancy to make it easier to test
- Add Support for Shrine buffs from The Gull and staff Rune craft [\#8457](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8457) ([LocalIdentity](https://github.com/LocalIdentity))
- Add poedb.tw to import website list [\#8401](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8401) ([Chuanhsing](https://github.com/Chuanhsing))
- Basic Unicode support [\#8412](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8412) ([zao](https://github.com/zao))
- Implement ability to delete folders with contents [\#8416](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8416) ([Paliak](https://github.com/Paliak))
### Fixed Crashes
- Fix crash related to trigger calculations [\#8392](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8392) ([Paliak](https://github.com/Paliak))
### Fixed Calculations
- Fix Viper Strike of Mamba poison [\#8253](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8253) ([Regisle](https://github.com/Regisle))
- Improve EHP accuracy [\#8430](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8430) ([Edvinas-Smita](https://github.com/Edvinas-Smita))
- Fixed Non-Damaging Ailment issue with Critical Mastery in Calc Screen [\#8393](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8393) ([Jonathan-Dang](https://github.com/Jonathan-Dang))
### Fixed Behaviours
- Fixed interaction between block replacement effect from Determined Survivor and Necromantic Aegis [\#8417](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8417) ([Jonathan-Dang](https://github.com/Jonathan-Dang))
- Disable "gain when hit" for builds which cannot survive unlucky hits [\#8342](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8342) ([Regisle](https://github.com/Regisle))
### User Interface
- Show Poison DPS in sidebar as the DPS for a single poison [\#8254](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8254) ([Regisle](https://github.com/Regisle))
### Fixed Bugs
- Fixes Cinderswallow Urn missing the damage taken mod [\#8419](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8419) ([n1tr0xs](https://github.com/n1tr0xs))
- Update Breathstealer's unique mods [\#8390](https://github.com/PathOfBuildingCommunity/PathOfBuilding/pull/8390) ([n1tr0xs](https://github.com/n1tr0xs))



## [v2.49.3](https://github.com/PathOfBuildingCommunity/PathOfBuilding/tree/v2.49.3) (2024/11/24)

[Full Changelog](https://github.com/PathOfBuildingCommunity/PathOfBuilding/compare/v2.49.2...v2.49.3)
Expand Down
Loading

0 comments on commit 988efe8

Please sign in to comment.