Skip to content

Commit

Permalink
fix: Don't allow negative duration for ignite
Browse files Browse the repository at this point in the history
  • Loading branch information
Wires77 committed Feb 4, 2022
1 parent 4d7fd90 commit 15697e0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/Modules/CalcOffence.lua
Original file line number Diff line number Diff line change
Expand Up @@ -3230,8 +3230,9 @@ function calcs.offence(env, actor, activeSkill)

local rateMod = (calcLib.mod(skillModList, cfg, "IgniteBurnFaster") + enemyDB:Sum("INC", nil, "SelfIgniteBurnFaster") / 100) / calcLib.mod(skillModList, cfg, "IgniteBurnSlower")
local durationBase = data.misc.IgniteDurationBase
local durationMod = calcLib.mod(skillModList, dotCfg, "EnemyIgniteDuration", "SkillAndDamagingAilmentDuration") * calcLib.mod(enemyDB, nil, "SelfIgniteDuration")
local durationMod = m_max(calcLib.mod(skillModList, dotCfg, "EnemyIgniteDuration", "SkillAndDamagingAilmentDuration") * calcLib.mod(enemyDB, nil, "SelfIgniteDuration"), 0)
globalOutput.IgniteDuration = durationBase * durationMod / rateMod * debuffDurationMult
globalOutput.IgniteDuration = globalOutput.IgniteDuration > data.misc.IgniteMinDuration and globalOutput.IgniteDuration or 0
local igniteStacks = (globalOutput.IgniteDuration / output.Time) / maxStacks
globalOutput.IgniteStackPotential = igniteStacks
if globalBreakdown then
Expand Down
1 change: 1 addition & 0 deletions src/Modules/Data.lua
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ data.misc = { -- magic numbers
PoisonDurationBase = 2,
IgnitePercentBase = 0.9,
IgniteDurationBase = 4,
IgniteMinDuration = 0.3,
ImpaleStoredDamageBase = 0.1,
BuffExpirationSlowCap = 0.25,
TrapTriggerRadiusBase = 10,
Expand Down

0 comments on commit 15697e0

Please sign in to comment.