Expose std::filesystem::remove_all functionality to lua side as an argument for RemoveDir #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation of RemoveDir does not allow for removal of direcoties with content. This commit adds a recursive boolean parameter to RemoveDir allowing for recursive removal of directories and their contents. PathOfBuildingCommunity/PathOfBuilding#8197
Wires77
reviewed
Jan 19, 2025
|
@Wires77 That's how it works (should, been a while). The param assert is only triggered if n > 1 and |
|
I was looking at the first usage of Lassert() and thinking that condition would fail if a second parameter wasn't passed in. I can build it test it myself to confirm though |
|
Just noting for posterity. I was wrong and i guess i designed the API to require the 2nd param for this func. Discussion moved to Discord. |
Paliak
added a commit
to Paliak/PathOfBuilding
that referenced
this pull request
Jan 19, 2025
This was referenced Jan 19, 2025
Merged
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Jan 20, 2025
Wires77
approved these changes
Jan 21, 2025
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of RemoveDir does not allow for removal of directories with content. This commit adds a recursive boolean parameter to RemoveDir allowing for recursive removal of directories and their contents.
See PathOfBuildingCommunity/PathOfBuilding#8197 for more discussion and potential use case.