fix: make file searches case-insensitive #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we moved from WinAPI `FindFirstFile` to `std::filesystem` path tests and globbing was accidentally made case-sensitive as we use direct string comparison or regular expressions to match files. We now always construct a regular expression for the glob and make the regex match case-insensitive. The regex is rebuilt on every file test but as the set of files is likely to be small this is of low impact; caching the regex in the search object would spread RE2 into the header.
Wires77
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we moved from WinAPI
FindFirstFiletostd::filesystempath tests and globbing was accidentally made case-sensitive as we use direct string comparison or regular expressions to match files.We now always construct a regular expression for the glob and make the regex match case-insensitive. The regex is rebuilt on every file test but as the set of files is likely to be small this is of low impact; caching the regex in the search object would spread RE2 into the header.