fix: point-filter window for even DPI factors #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We emulate DPI scaling by drawing to a smaller render target and scale it up with bilinear filtering to the desired DPI scale factor configured in the OS. Windows seems to do crisper point filtering (nearest neighbour) for scale factors that are multiples of 100%. This commit alters our behaviour to select the filter mode based on the DPI scale factor, opting for point filtering for non-fractional scaling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We emulate DPI scaling by drawing to a smaller render target and scale it up with bilinear filtering to the desired DPI scale factor configured in the OS.
Windows seems to do crisper point filtering (nearest neighbour) for scale factors that are multiples of 100%.
This commit alters our behaviour to select the filter mode based on the DPI scale factor, opting for point filtering for non-fractional scaling.