Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating hosting docker sample #6853

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Updating hosting docker sample #6853

merged 3 commits into from
Sep 27, 2024

Conversation

cquirosj
Copy link
Contributor

@cquirosj cquirosj commented Sep 26, 2024 •
edited
Loading

Addressing feedback

Changes:

  • removing version attribute from docker-compose files - no longer required
  • adding prerequisites section
  • removing explicit package reference (Microsoft.Net.Build.Containers) since it is now included in the SDK
  • adding required attribute to projects now that an explicit reference to the package is not required

@cquirosj cquirosj changed the title updating hosting docker sample Updating hosting docker sample Sep 26, 2024
@cquirosj cquirosj marked this pull request as ready for review September 26, 2024 21:22
DavidBoike
DavidBoike approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@DavidBoike DavidBoike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestion

samples/hosting/docker/sample.md Outdated Show resolved Hide resolved
@cquirosj cquirosj merged commit 711988e into master Sep 27, 2024
4 checks passed
@cquirosj cquirosj deleted the docker-host-sample-update branch September 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBoike DavidBoike DavidBoike approved these changes

@awright18 awright18 awright18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cquirosj @DavidBoike @awright18