Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Vanilla TypeScript sample #62

Closed
wants to merge 8 commits into from
Closed

Conversation

mauroservienti
Copy link
Member

WIP don't merge

Vanilla TypeScript sample

PoA

  • WebAPI hosts to expose real sales and shipping data
  • super simple SPA to read and compose data coming from back-end directly in the browser

Description

This PR introduces a demo of a composite UI hosting the composition infrastructure directly inside the SPA built using TypeScript

@mauroservienti mauroservienti self-assigned this May 11, 2017
@mauroservienti mauroservienti mentioned this pull request Oct 3, 2017
11 tasks
@mauroservienti mauroservienti requested a review from a team October 10, 2017 08:35
@adamralph
Copy link
Contributor

adamralph commented Oct 24, 2017

Would it be better to use the existing demo endpoints, and add a third solution which has only the typescript SPA project plus the necessary backend endpoints?

@mauroservienti
Copy link
Member Author

there are pros and cons, moving these along with the other 2 demos (that are already mixed) might complicate a lot evolution, simply because when one solution is open we might change something that works in the open solution but breaks others. I'd prefer them to be separated, the actual 2 .NET Core demos together are already too complex IMO.

@mauroservienti
Copy link
Member Author

especially now that @HEskandari is working on the polymer one, there will be a fourth one

@adamralph
Copy link
Contributor

@mauroservienti would it help if we put the two current demos back into the same solution, as you originally had it? Now that I'm more familiar with the code, I think it may make more sense.

@mauroservienti
Copy link
Member Author

it solves the problem but open up the nightmare of multiple startup profiles when you want to switch from demo x to demo y

@adamralph
Copy link
Contributor

Would it not be a case if switching just one of the projects each time, e.g. Composition Gateway/MVC/ Typescript/Polymer? All the other start up projects would remain the same, no?

@mauroservienti
Copy link
Member Author

Yes, but you still need to use that crappy multiple startup projects VS dialog to change one project in the list. Be aware, I'm not against merging it'll make back-ends evolution much simpler, but at the same time every single time we evolve a back-end all front-ends demos must be kept in sync in one go, otherwise they'll be broken.

@adamralph
Copy link
Contributor

you still need to use that crappy multiple startup projects VS dialog to change one project in the list

Personally I'm fine with that. Switching one project off and another on is simple enough.

every single time we evolve a back-end all front-ends demos must be kept in sync in one go

Fair point, but I'm wondering which is the lesser of two evils. Having to rev all the front end projects synchronously, or having to maintain 4 separate sets of back end projects.

@mauroservienti
Copy link
Member Author

my question is: are you familiar with polymer or typescript or WPF or whatever stack we have in the pipeline? the more front-ends stack we have the more complex updating them will become in one go. It'll also make a change dependent on many different people.

We can always try and split them again in the future.

Copy link
Contributor

@adamralph adamralph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, we won't be putting any concerted effort into this just yet.

@mauroservienti
Copy link
Member Author

Closing for now, I’ll re-open as I have bandwidth to work on this again.

@mauroservienti
Copy link
Member Author

I’d leave the branch in place so to not lose anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants