Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileShareDataBus acceptance tests for multi environments #7050

Merged
merged 2 commits into from
Jun 4, 2024
Merged

FileShareDataBus acceptance tests for multi environments #7050

merged 2 commits into from
Jun 4, 2024

Conversation

jpalac
Copy link
Contributor

@jpalac jpalac commented Jun 3, 2024 •
edited by ramonsmits
Loading

Added a test to ensure databus message from windows to linux (and vice versa) are processed correctly via the FileShareDataBus.

@jpalac jpalac marked this pull request as ready for review June 3, 2024 04:40
johnsimons
johnsimons approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@johnsimons johnsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because @jpalac asked me nicely 😄

@jpalac jpalac merged commit fbf2b2c into master Jun 4, 2024
3 checks passed
@jpalac jpalac deleted the databus-acceptance-tests branch June 4, 2024 00:24
This was referenced Jun 4, 2024
Merged
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsimons johnsimons johnsimons approved these changes

@abparticular abparticular abparticular approved these changes

@ramonsmits ramonsmits Awaiting requested review from ramonsmits

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpalac @johnsimons @abparticular