Fix SkipSerialization leak #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquirosj
approved these changes
Apr 20, 2022
timbussmann
added a commit
that referenced
this pull request
Apr 20, 2022
timbussmann
added a commit
that referenced
this pull request
Apr 20, 2022
This was referenced Apr 20, 2022
timbussmann
added a commit
that referenced
this pull request
Apr 20, 2022
timbussmann
added a commit
that referenced
this pull request
Apr 20, 2022
timbussmann
added a commit
that referenced
this pull request
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #6223
The
SkipSerializationconfiguration can leak into nested sends, preventing nested sends to be correctly deserialized. This could lead to complete message loss as the receiving endpoint might discard the message due to the missing body.This setting is currently only used by callbacks.
Since
MessageOperationPropertiesare read-only, the behavior needs to set values scoped to the current message operation, which can be identified by the message id.