Task-based notifications API #5449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbussmann
requested review from
danielmarbach,
andreasohlund,
SeanFeldman and
SzymonPobiega
|
thoughts on these changes @SimonCropp @gbiellem ? |
...erviceBus.Core.Tests/ApprovalFiles/APIApprovals.ApproveNServiceBus.netframework.approved.txt
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/Recoverability/Settings/DelayedRetriesSettings.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/Recoverability/Settings/ImmediateRetriesSettings.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/Recoverability/Settings/ImmediateRetriesSettings.cs
Show resolved
Hide resolved
src/NServiceBus.Core/Recoverability/Settings/RetryFailedSettings.cs
Outdated
Show resolved
Hide resolved
|
Based on the opinions I heard from people chiming on this I decided to remove the sync overloads. While I think this causes more friction for users and therefore is a bad change, I can accept the argument that we never provided sync+async APIs in combination so far and that this is a more advanced API which might not be the right place to drive "new approaches" to this topic. |
SzymonPobiega
approved these changes
Oct 9, 2019
danielmarbach
approved these changes
Oct 9, 2019
@timbussmann re-request review when that's done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5393
Provides a new notification API which is based on the internal notifications infrastructure which can support async notification subscribers.
The new APIs have been moved to the corresponding recoverability configuration settings and I've tried to give them more accurate and meaningful names.