Add configuration API for In memory gateway deduplication persistence #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SzymonPobiega
requested changes
Jun 19, 2019
src/NServiceBus.Core/Persistence/InMemory/Gateway/InMemoryGatewayDeduplication.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/Persistence/InMemory/Gateway/InMemoryGatewayDeduplicationFeature.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/Persistence/InMemory/Gateway/InMemoryGatewayDeduplicationFeature.cs
Outdated
Show resolved
Hide resolved
src/NServiceBus.Core/Persistence/InMemory/Gateway/InMemoryGatewayDeduplication.cs
Outdated
Show resolved
Hide resolved
ramonsmits
changed the title
ramonsmits
force-pushed
the
InMemoryGatewayDeduplication-LRU
branch
from
6b2de96 to
c420c54
Compare
SzymonPobiega
previously approved these changes
Jun 19, 2019
|
Closing in favor for #5397 |
ramonsmits
changed the title
|
Awaiting #5397 to be merged first |
SzymonPobiega
previously approved these changes
Jun 21, 2019
ramonsmits
changed the title
ramonsmits
force-pushed
the
InMemoryGatewayDeduplication-LRU
branch
from
1b6490d to
8e943c7
Compare
ramonsmits
changed the title
ramonsmits
force-pushed
the
InMemoryGatewayDeduplication-LRU
branch
from
8e943c7 to
f8b52db
Compare
ramonsmits
force-pushed
the
InMemoryGatewayDeduplication-LRU
branch
from
f8b52db to
2d55aa6
Compare
timbussmann
approved these changes
Jul 2, 2019
| @@ -6,7 +6,8 @@ public class ConfigureEndpointInMemoryPersistence : IConfigureEndpointTestExecut | |||
| { | |||
| public Task Configure(string endpointName, EndpointConfiguration configuration, RunSettings settings, PublisherMetadata publisherMetadata) | |||
| { | |||
| configuration.UsePersistence<InMemoryPersistence>(); | |||
| configuration.UsePersistence<InMemoryPersistence>() | |||
| .GatewayDeduplicationCacheSize(100); | |||
There was a problem hiding this comment.
unless necessary, I'd vote to not "randomly configure" this setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRU based to contraint the number of items. Refactored to also remove an O(n) operation.