Merge pull request #5253 from Particular/hotfix-7.1.3

Hotfix 7.1.3
Particular · Aug 30, 2018 · 4563c1f · 4563c1f
2 parents b62c800 + 86867fe
commit 4563c1f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/NServiceBus.Core.Analyzer.Tests/AwaitOrCaptureTasksAnalyzerTests.cs b/src/NServiceBus.Core.Analyzer.Tests/AwaitOrCaptureTasksAnalyzerTests.cs
@@ -58,6 +58,10 @@ public class AwaitOrCaptureTasksAnalyzerTests : DiagnosticVerifier
         [TestCase("IMessageSession", "obj.Unsubscribe(typeof(object));")]
         [TestCase("IMessageSession", "obj.Unsubscribe<object>();")]
 
+        // ScheduleExtensions
+        [TestCase("IMessageSession", "obj.ScheduleEvery(TimeSpan.Zero, _ => Task.FromResult(0));")]
+        [TestCase("IMessageSession", "obj.ScheduleEvery(TimeSpan.Zero, \"name\", _ => Task.FromResult(0));")]
+
         // Endpoint
         [TestCase("EndpointConfiguration", "Endpoint.Create(obj);")]
         [TestCase("EndpointConfiguration", "Endpoint.Start(obj);")]
@@ -70,7 +74,9 @@ public class AwaitOrCaptureTasksAnalyzerTests : DiagnosticVerifier
         public Task DiagnosticIsReportedForCorePublicMethods(string type, string call)
         {
             var source =
-$@"using NServiceBus;
+$@"using NServiceBus; 
+using System;
+using System.Threading.Tasks; 
 class Foo
 {{
     void Bar({type} obj)
@@ -83,7 +89,7 @@ void Bar({type} obj)
             {
                 Id = "NSB0001",
                 Severity = DiagnosticSeverity.Error,
-                Locations = new[] { new DiagnosticResultLocation("Test0.cs", 6, 9) },
+                Locations = new[] { new DiagnosticResultLocation("Test0.cs", 8, 9) },
             };
 
             return Verify(source, expected);

diff --git a/src/NServiceBus.Core.Analyzer/AwaitOrCaptureTasksAnalyzer.cs b/src/NServiceBus.Core.Analyzer/AwaitOrCaptureTasksAnalyzer.cs
@@ -73,6 +73,7 @@ static bool IsMethodRequiringAwait(ExpressionSyntax call, SyntaxNodeAnalysisCont
             "NServiceBus.IMessageProcessingContext.Reply",
             "NServiceBus.IMessageProcessingContext.ForwardCurrentMessageTo",
             "NServiceBus.IMessageProcessingContextExtensions.Reply",
+            "NServiceBus.ScheduleExtensions.ScheduleEvery",
             "NServiceBus.Saga.RequestTimeout",
             "NServiceBus.Saga.ReplyToOriginator",
             "NServiceBus.Endpoint.Create",