Skip to content

Commit

Permalink
fix: Make both firewall states as valid ones
Browse files Browse the repository at this point in the history
  • Loading branch information
dz0ny committed Sep 27, 2024
1 parent 5c78d8e commit 9b1c8a3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions Pareto/Checks/Claim.swift
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ class Claim: Hashable {

func run() {
for check in checks {
let state = check.run()
os_log("%{public}s: %{public}s", log: Log.check, check.Title , state)
check.run()

Check warning on line 68 in Pareto/Checks/Claim.swift

View workflow job for this annotation

GitHub Actions / Build and Archive SetApp

result of call to 'run()' is unused

Check warning on line 68 in Pareto/Checks/Claim.swift

View workflow job for this annotation

GitHub Actions / Build and Archive SetApp

result of call to 'run()' is unused

Check warning on line 68 in Pareto/Checks/Claim.swift

View workflow job for this annotation

GitHub Actions / Build and Archive Native

result of call to 'run()' is unused

Check warning on line 68 in Pareto/Checks/Claim.swift

View workflow job for this annotation

GitHub Actions / Build and Archive Native

result of call to 'run()' is unused
}
}

Expand Down
3 changes: 1 addition & 2 deletions Pareto/Checks/Firewall and Sharing/Firewall.swift
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ class FirewallCheck: ParetoCheck {
override func checkPasses() -> Bool {
if #available(macOS 15, *) {
let out = runCMD(app: "/usr/libexec/ApplicationFirewall/socketfilterfw", args: ["--getglobalstate"])
return out.contains("enabled")

return out.contains("State = 1") || out.contains("State = 2")
} else {
let native = readDefaultsFile(path: "/Library/Preferences/com.apple.alf.plist")

Expand Down
2 changes: 1 addition & 1 deletion Pareto/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>5460</string>
<string>5462</string>
<key>LSApplicationCategoryType</key>
<string>public.app-category.utilities</string>
<key>LSMinimumSystemVersion</key>
Expand Down

0 comments on commit 9b1c8a3

Please sign in to comment.