Skip to content
This repository has been archived by the owner on Mar 29, 2020. It is now read-only.

1.5 Map conversion update #560

Merged
merged 2 commits into from
Jun 3, 2018
Merged

1.5 Map conversion update #560

merged 2 commits into from
Jun 3, 2018

Conversation

IohannesIohannium
Copy link
Contributor

As stated in #535.

Fixed some minor border tweaks, notably:

  • Cameroonian-Nigerian border
  • Split Agades (Niger) state
  • Serbian Southern borders (Kosovo and Macedonia)
  • Uruguayan border with Brazil
  • Some cities' locations

Along with some country mappings fixes based on the new formable tags and Guyenne/Gascony fix.

I'm sorry about the reordering of the province mappings file.

Guyenne-Gascony fix and minor tweaks
Some minor border fixes
@Idhrendur Idhrendur added this to the Vic2 to HoI4 Cornflakes Update milestone Jun 1, 2018
@Idhrendur
Copy link
Member

I want to give this a quick spot check, but need to do so from home. But I'd like to get it in the next release. It looks like you've addressed some of the regions I was pretty unsure about.

@Idhrendur Idhrendur changed the base branch from Vic2ToHoI4 to Vic2ToHoI4-mapUpdate June 3, 2018 15:31
@Idhrendur Idhrendur merged commit f430b1d into ParadoxGameConverters:Vic2ToHoI4-mapUpdate Jun 3, 2018
@Idhrendur
Copy link
Member

I was looking this over, and the province mapping file is structured completely differently. What were you doing to get everything in a different order and most of the comments dropped?

@IohannesIohannium
Copy link
Contributor Author

I based it on the province mapping file I created a lot of months ago (through a compared map-on-map method) and constantly updated since for I don't know why.

@IohannesIohannium IohannesIohannium deleted the patch-5 branch June 3, 2018 16:25
@Idhrendur
Copy link
Member

Ah, that's a bummer. The regions you noted were ones I had a rough time going over, even when I was using both your version and the original version to create the current version. I'd love to see them fixed up.

@IohannesIohannium IohannesIohannium restored the patch-5 branch June 4, 2018 17:38
@Idhrendur Idhrendur removed this from the Vic2 to HoI4 Cornflakes Update milestone Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants