Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a cmake target for the commons library #272

Merged
merged 42 commits into from
Dec 24, 2024
Merged

Create a cmake target for the commons library #272

merged 42 commits into from
Dec 24, 2024

Conversation

Idhrendur
Copy link
Member

Allows other projects to just import the library instead of adding the files to their own projects.

Zemurin
Zemurin approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@Zemurin Zemurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 0 knowledge of cmake scripting. I assume this doesn't get imported anywhere but is only for commons standalone builds.

IhateTrains
IhateTrains approved these changes Dec 24, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
@Idhrendur Idhrendur merged commit 3d00ea8 into master Dec 24, 2024
14 checks passed
@Idhrendur Idhrendur deleted the cmake branch December 24, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zemurin Zemurin Zemurin approved these changes

@IhateTrains IhateTrains IhateTrains approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Idhrendur @Zemurin @IhateTrains