Make CoaMapper internal, reduce interface use (#2362)

ImperatorToCK3/CK3/Titles/LandedTitles.cs

@@ -147,7 +147,7 @@ public Title Add(string id) {
 			return newTitle;
 		}
 
-		public Title Add(
+		internal Title Add(
 			Country country,
 			Dependency? dependency,
 			CountryCollection imperatorCountries,
@@ -191,7 +191,7 @@ IReadOnlyCollection<string> enabledCK3Dlcs
 			return newTitle;
 		}
 
-		public Title Add(
+		internal Title Add(
 			string id,
 			Governorship governorship,
 			Country country,
@@ -340,7 +340,7 @@ public void CleanUpHistory(CharacterCollection characters, Date ck3BookmarkDate)
 			}
 		}
 
-		public void ImportImperatorCountries(
+		internal void ImportImperatorCountries(
 			CountryCollection imperatorCountries,
 			IReadOnlyCollection<Dependency> dependencies,
 			TagTitleMapper tagTitleMapper,
@@ -497,7 +497,7 @@ private void ImportImperatorCountry(
 			}
 		}
 
-		public void ImportImperatorGovernorships(
+		internal void ImportImperatorGovernorships(
 			Imperator.World irWorld,
 			ProvinceCollection ck3Provinces,
 			TagTitleMapper tagTitleMapper,
@@ -1617,7 +1617,7 @@ public void LoadCulturalNamesFromConfigurables() {
 			parser.ParseFile(filePath);
 		}
 
-		public void SetCoatsOfArms(CoaMapper coaMapper) {
+		internal void SetCoatsOfArms(CoaMapper coaMapper) {
 			Logger.Info("Setting coats of arms for CK3 titles...");
 
 			int counter = 0;

ImperatorToCK3/CK3/Titles/Title.cs

@@ -174,7 +174,7 @@ private Title(Title? baseTitle, Title overrideTitle, LandedTitles parentCollecti
 			vassal.DeJureLiege = this;
 		}
 	}
-	public void InitializeFromTag(
+	internal void InitializeFromTag(
 		Country country,
 		Dependency? dependency,
 		CountryCollection imperatorCountries,

ImperatorToCK3/CK3/World.cs

@@ -59,7 +59,7 @@ public sealed class World {
 	public MapData MapData { get; private set; } = null!;
 	public IList<Wars.War> Wars { get; } = new List<Wars.War>();
 	public LegendSeedCollection LegendSeeds { get; } = [];
-	public CoaMapper CK3CoaMapper { get; private set; } = null!;
+	internal CoaMapper CK3CoaMapper { get; private set; } = null!;
 	private readonly List<string> enabledDlcFlags = [];
 
 	/// <summary>

ImperatorToCK3/Imperator/World.cs

@@ -52,7 +52,7 @@ public partial class World {
 	private readonly PopCollection pops = [];
 	public ProvinceCollection Provinces { get; } = [];
 	public CountryCollection Countries { get; } = [];
-	public CoaMapper CoaMapper { get; private set; } = new();
+	internal CoaMapper CoaMapper { get; private set; } = new();
 	public MapData MapData { get; private set; }
 	public AreaCollection Areas { get; } = [];
 	public ImperatorRegionMapper ImperatorRegionMapper { get; private set; }

ImperatorToCK3/Mappers/CoA/CoaMapper.cs

@@ -5,7 +5,7 @@
 
 namespace ImperatorToCK3.Mappers.CoA;
 
-public sealed class CoaMapper {
+internal sealed class CoaMapper {
 	public CoaMapper() { }
 	public CoaMapper(ModFilesystem modFS) {
 		Logger.Info("Parsing CoAs...");
@@ -53,7 +53,7 @@ public void ParseCoAs(IEnumerable<string> coaDefinitionStrings) {
 	/// <summary>
 	/// For a given collection of flag names, returns ones that don't have a defined CoA.
 	/// </summary>
-	public ISet<string> GetAllMissingFlagKeys(IEnumerable<string> flagKeys) {
+	public HashSet<string> GetAllMissingFlagKeys(IEnumerable<string> flagKeys) {
 		var existingFlagKeys = coasMap.Keys.ToHashSet();
 		return flagKeys.Where(flagKey => !existingFlagKeys.Contains(flagKey)).ToHashSet();
 	}

ImperatorToCK3/Outputter/CoatOfArmsOutputter.cs

@@ -11,7 +11,7 @@
 
 namespace ImperatorToCK3.Outputter;
 public static class CoatOfArmsOutputter {
-	public static async Task OutputCoas(string outputModPath, Title.LandedTitles titles, IEnumerable<Dynasty> dynasties, CoaMapper ck3CoaMapper) {
+	internal static async Task OutputCoas(string outputModPath, Title.LandedTitles titles, IEnumerable<Dynasty> dynasties, CoaMapper ck3CoaMapper) {
 		Logger.Info("Outputting coats of arms...");
 
 		// Output variables (like "@smCastleX = 0.27" in vanilla CK3).