Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix belt disappearing on mouse drop #28188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-dzianishchyts
Copy link
Contributor

@m-dzianishchyts m-dzianishchyts commented Jan 30, 2025

What Does This PR Do

Stops belts from disappearing on mouse drop when the wearer is being grabbed be their neck.
I believe /obj/item/storage/MouseDrop() completely overlaps /obj/item/storage/belt/MouseDrop() functionality, so the latter can be removed.

Why It's Good For The Game

Fixes a bug.

Testing

  • Belt is ok being mouse dragged to a hand and back to its slot.
  • Can't mouse drag the belt while being grabbed by the neck.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑 Maxiemar
fix: Belts no longer disappear when being mouse dragged to a hand while the wearer is being grabbed by their neck.
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants