fix two vermin infestation issues #28181
Open
+21
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
the
-Status: Awaiting review
Burzah
approved these changes
Jan 31, 2025
ParadiseSS13-Bot
added
-Status: Awaiting merge
lewcc
approved these changes
Jan 31, 2025
|
|
||
| log_debug("Failed to locate area for infestation event!") | ||
| kill() | ||
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR fixes two issues with the vermin infestation event. The first is that locating an area always returns a result, even if that area has no turfs, meaning a station without the chosen area (like Meta using Turbine instead of Incinerator) will silently fail. The second is that the
turf_clearmethod it was using for checking for available spawn points was awful, essentially excluding any floor with any contents whatsoever: lights, underfloor cables, etc. This meant that for example, Metastation tech storage was seen as having no eligible turfs for spawning:Despite having tons of floor space.
Why It's Good For The Game
More reliable event.
Testing
Used event manager to run Vermin Infestation event, ensured results were still random and all expected locations worked.
Declaration
Changelog
🆑
fix: Vermin infestation events will now more reliably trigger.
/:cl: