Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slime People and IPC; Imitating Species Cosmetically. #27359

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Slime People and IPC; Imitating Species Cosmetically. #27359

wants to merge 24 commits into from
+684 −444

Conversation

Spaghetti-bit
Copy link
Contributor

@Spaghetti-bit Spaghetti-bit commented Nov 14, 2024 •
edited
Loading

What Does This PR Do

Allows slime people and IPCs to imitate other species. This provides no mechanical benefit, and is purely cosmetic.

Slime People:

  • Round-Start / loadout species 'sub-type'.
  • In-Round changing of sub type by using an action and standing still for 10 seconds, costs the same as regenerating a limb.

IPC:

  • Round-Start / loadout species 'sub-type'.
  • In-Round changing via identity configuration surgery

LATER DOWN THE ROAD: ( I just need sprites 😭 )

  • Species specific augmentation / cybernetic limbs.

Why It's Good For The Game

More customization on top of more chances for disguises. Also allows for more diverse characters.

Images of changes

Slime imitation of a nian
image
Slime imitation of a unathi
image

IPC imitation of a vox and unathi
image

Testing

Lots of spawning in as the above species and changing 'sub-types'.
DB sql tested.
Link processing tested.
Morph form tested.
Identity configuration tested.

Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

image

Changelog

🆑
add: Added the ability for IPCs to imitate other species. This can be accessed via the character creator menu or in game via robotics surgery.
add: Added the ability for Slime People to imitate other species. This can be done via the character creator menu or in game via the 'morph form' action which requires the slime person to stand still for 10 seconds before being allowed to choose a new species to imitate, costs the same as regenerating a limb.
/:cl:

@AffectedArc07
Copy link
Member

In round changing sounds terrifying from a balance POV.

AffectedArc07
AffectedArc07 requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First tiny pass

code/__DEFINES/flags.dm
#define BALD (1<<14)
#define ALL_RPARTS (1<<15)
#define SHAVED (1<<16)
#define HAS_SPECIES_SUBTYPE (1<<14)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this to not be at the end and not shift the existing ones?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was to be in line with the rest of HAS_[blank]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

code/modules/client/preference/character.dm
@@ -416,45 +421,45 @@
gender = query.item[4]
age = text2num(query.item[5])
species = query.item[6]
language = query.item[7]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the select query for this.

Also please append it to the end as opposed to changing all these indexes around.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the indexes around to fit in line with the //character selects. But I'll append it to the end.

@SynthTwo
Copy link
Contributor

!wiki_label

@github-actions github-actions bot added Requires Wiki Update Useful for Wiki Contributers to search for things that need updating Merge Conflict This PR is merge conflicted labels Nov 14, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally SQL Change This PR modifies the game database. This PR must go through the host. Configuration Change This PR changes the game configuration files. Please run via the host. labels Nov 14, 2024
@Adrer Adrer added the Feature This PR is a new addition to the game label Nov 15, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Nov 15, 2024
AffectedArc07
AffectedArc07 requested changes Nov 16, 2024
View reviewed changes
Copy link
Member

@AffectedArc07 AffectedArc07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to update code\modules\client\login_processing\20-load_characters.dm

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Nov 22, 2024
Burzah
Burzah requested changes Nov 24, 2024
View reviewed changes
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL version bump!
Make sure to change the script from 61-62.sql to 62-63.sql

code/__DEFINES/misc_defines.dm Outdated
@@ -423,7 +423,7 @@
#define INVESTIGATE_HOTMIC "hotmic"

// The SQL version required by this version of the code
#define SQL_VERSION 61
#define SQL_VERSION 62
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define SQL_VERSION 62
#define SQL_VERSION 63

config/example/config.toml Outdated
[database_configuration]
# This section contains all the settings for the ingame database
# If you are running in production, you will want to be using a database

# Enable/disable the database on a whole
sql_enabled = false
# SQL version. If this is a mismatch, round start will be delayed
sql_version = 61
sql_version = 62
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
sql_version = 62
sql_version = 63

@spacegeese
Copy link
Contributor

you can very easily become a blue Unathi-like slimeperson

a solution for this is that you would need to be next to a person of that species to transform into them like plastic man

@github-actions GitHub Actions
Copy link
Contributor

This pull request seems to be stale as there have been no changes in 14 days, please make changes within 7 days or the PR will be closed. If you believe this is a mistake, please inform a development team member on Discord.

@github-actions github-actions bot added the Stale This PR has been left inactive and requires an update. label Dec 13, 2024
@Burzah Burzah added Stale Exempt This topic is exempt from becoming stale... Must have bribed a maintainer. and removed Stale This PR has been left inactive and requires an update. labels Dec 14, 2024
@DGamerL DGamerL added Stale This PR has been left inactive and requires an update. Stale Exempt This topic is exempt from becoming stale... Must have bribed a maintainer. and removed Stale Exempt This topic is exempt from becoming stale... Must have bribed a maintainer. Stale This PR has been left inactive and requires an update. labels Jan 1, 2025
@Spaghetti-bit
Copy link
Contributor Author

Working on this once more.

@Spaghetti-bit Spaghetti-bit force-pushed the TerminatorMachinesAndMorphlingSlimes branch from 2b5614e to e7b76e9 Compare January 30, 2025 02:28
@Spaghetti-bit Spaghetti-bit reopened this Jan 30, 2025
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Jan 30, 2025
@Spaghetti-bit
+63-64.sql
bec00d1 
> species_subtype after pda_ringtone

IPC identity configuration surgery.

Slime "Morph" action: 10 seconds. Allows a slime person to change how they look.
> Same cost as regenerating a limb.

Link processing subspecies implement.
@Spaghetti-bit
Pain2
9b9683f
@Spaghetti-bit Spaghetti-bit requested a review from Burzah January 30, 2025 11:34
@Spaghetti-bit
Copy link
Contributor Author

Ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Burzah Burzah Awaiting requested review from Burzah

@AffectedArc07 AffectedArc07 Awaiting requested review from AffectedArc07 AffectedArc07 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@AffectedArc07 AffectedArc07

Labels
-Status: Awaiting review This PR is awaiting review from the review team Configuration Change This PR changes the game configuration files. Please run via the host. Feature This PR is a new addition to the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating SQL Change This PR modifies the game database. This PR must go through the host. Stale Exempt This topic is exempt from becoming stale... Must have bribed a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Spaghetti-bit @AffectedArc07 @SynthTwo @Gatchapod @spacegeese @Burzah @ParadiseSS13-Bot @Adrer @DGamerL