Dolphins search for treasure toggle

[HexedHero]

I saw dolphins sync loading chunks on timings/spark almost every time I fed them fish, can be abused to heavily lag the server over and over and with multiple dolphins to almost have a player-caused deadlock. Tested locally.

[Phoenix616]

I guess it doesn't hurt to have a full toggle for that function but isn't the impact already easily mitigable by using the seed based feature search? If that still causes sync loads then that would seem like a bug in that patch... maybe because it forces it to search non-discovered locations? The treasure-maps-return-already-discovered option obviously only applies to maps but the dolphins use the same method. (Although only with a radius of 50)

EDIT: Actually I just looked at my patches and saw that I already noticed that: The seed-based feature search will still load at least one chunk sync (which could even trigger chunk generation) which is necessary to get the exact structure location from the chunk data. The solution I came up with to simply return the chunk corner might not be exact enough (especially for Dolphins) and it also has the issue of pointing to y=0 making the Dolphin potentially try to swim to the bottom or something? Returns center now and checks if chunk isn't loaded which should make it more precise.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[HexedHero]

Root issue fixed by #5760