Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumPy compatibility enhancements #3907

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Nov 23, 2024

PR types

Others

PR changes

Others

Describe

This pull request includes several changes to improve the code quality and consistency in the paddlespeech/s2t/models/wav2vec2/modules/modeling_wav2vec2.py and paddlespeech/s2t/models/wavlm/wavlm_paddle.py files. The changes primarily focus on updating data types, reformatting code for readability, and organizing imports.

Data type updates:

  • Updated the data type from np.bool to np.bool_ in various functions to align with the latest NumPy standards. (modeling_wav2vec2.py: [1] [2]; wavlm_paddle.py: [3] [4]

Code reformatting:

Import organization:

reference

Copy link

paddle-bot bot commented Nov 23, 2024

Thanks for your contribution!

@mergify mergify bot added S2T asr/st T2S labels Nov 23, 2024
Copy link
Collaborator

@zxcd zxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxcd zxcd merged commit 61728f8 into PaddlePaddle:develop Nov 26, 2024
5 checks passed
@GreatV GreatV deleted the numpy_compatibility branch November 26, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants