Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line 445 program.py #13389

Merged
merged 1 commit into from
Jul 15, 2024
Merged

line 445 program.py #13389

merged 1 commit into from
Jul 15, 2024

Conversation

ManikSinghSarmaal
Copy link
Contributor

@ManikSinghSarmaal ManikSinghSarmaal commented Jul 15, 2024

refering to-https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/incubate/ModelAverage_en.html

it should be paddle.incubate.ModelAverage and not paddle.incubate.optimizer.ModelAverage

refering to-https://www.paddlepaddle.org.cn/documentation/docs/en/api/paddle/incubate/ModelAverage_en.html

it should be paddle.incunate.ModelAverage and paddle.incubate.optimizer.ModelAverage
@CLAassistant
Copy link

CLAassistant commented Jul 15, 2024

CLA assistant check
All committers have signed the CLA.

@GreatV
Copy link
Collaborator

GreatV commented Jul 15, 2024

Thank you for your contribution, I'm more curious if the previous form of the code leads to training errors?

@ManikSinghSarmaal
Copy link
Contributor Author

Thank you for your contribution, I'm more curious if the previous form of the code leads to training errors?

I have not used the use_srn flag that is for config["Architecture"]["algorithm"] == "SRN", I was going around the code and checking website at the same time so came across this, I don't think so it will usually lead to any training errors but to be on the safe side always😄

Copy link
Collaborator

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GreatV GreatV merged commit 5347be7 into PaddlePaddle:main Jul 15, 2024
3 checks passed
@luotao1
Copy link
Collaborator

luotao1 commented Oct 15, 2024

@ManikSinghSarmaal Thanks for your contribution! You will receive a beautiful PaddlePaddle gift. Please provide your mailing address by filling out the following questionnaire before October 18th.

Looking forward to the future, we will walk further together in the world of open source!
Click Here :https://paddle.wjx.cn/vm/h4On9gJ.aspx#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants