Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some bugs that caused PPOCRLabel to crash, added ability to expand checkboxes #11236

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

g39088902
Copy link
Contributor

PR 类型 PR types

[ New features | Bug fixes ]

PR 变化内容类型 PR changes

[ Models ]

描述 Description

1、PPOCRLabel现在支持从中文路径导入图片,原本导入含中文路径的图片会导致崩溃。
2、PPOCRLabel现在支持移动被其他框覆盖的锚点,原本无法移动被覆盖的锚点。
3、修复utility.py中误输入字符导致的语法错误。
4、修复setValue()应输入int,实际输入float导致的类型错误。
5、修复paddleocr中未import predict_system的错误。
6、修复canvas.py中部分输入参数类型错误
7、修复了LabelList不兼容搜狗输入法或win11输入法的问题。原本使用搜狗输入法修改标注数据时,仅输入一个字母就会失去焦点并提交数据变更,导致无法输入完整的汉字。现在将处理逻辑改为失去焦点时仍不提交数据变更,直到切换item或按下enter键才提交。
8、新增扩大选框的功能

1、PPOCRLabel now supports importing images from Chinese paths, originally importing images containing Chinese paths would cause a crash.
2、PPOCRLabel now supports moving anchor points that are covered by other boxes, originally it could not move the covered anchor points.
3、Fix the syntax error caused by mistakenly inputting characters in utility.py.
4、Repair the type error caused by inputting int but float in setValue().
5、Repair the error of not import predict_system in paddleocr.
6、Fix some input parameter type errors in canvas.py.
7、LabelList can't use Sogou Input Method or Win11 Input Method to input text.
8、Add function of expand box.

提PR之前的检查 Check-list

  • 这个 PR 是提交到dygraph分支或者是一个cherry-pick,否则请先提交到dygarph分支。
    This PR is pushed to the dygraph branch or cherry-picked from the dygraph branch. Otherwise, please push your changes to the dygraph branch.
  • 这个PR清楚描述了功能,帮助评审能提升效率。This PR have fully described what it does such that reviewers can speedup.
  • 这个PR已经经过本地测试。This PR can be convered by current tests or already test locally by you.

g39088902 and others added 2 commits November 10, 2023 11:36
2、PPOCRLabel现在支持移动被其他框覆盖的锚点,原本无法移动被覆盖的锚点。
3、修复utility.py中误输入字符导致的语法错误。
4、修复setValue()应输入int,实际输入float导致的类型错误。
5、修复paddleocr中未import predict_system的错误。
6、修复canvas.py中部分输入参数类型错误
7、修复了LabelList不兼容搜狗输入法或win11输入法的问题。原本使用搜狗输入法修改标注数据时,仅输入一个字母就会失去焦点并提交数据变更,导致无法输入完整的汉字。现在将处理逻辑改为失去焦点时仍不提交数据变更,直到切换item或按下enter键才提交。
8、新增扩大选框的功能

1、PPOCRLabel now supports importing images from Chinese paths, originally importing images containing Chinese paths would cause a crash.
2、PPOCRLabel now supports moving anchor points that are covered by other boxes, originally it could not move the covered anchor points.
3、Fix the syntax error caused by mistakenly inputting characters in utility.py.
4、Repair the type error caused by inputting int but float in setValue().
5、Repair the error of not import predict_system in paddleocr.
6、Fix some input parameter type errors in canvas.py.
7、LabelList can't use Sogou Input Method or Win11 Input Method to input text.
8、Add function of expand box.
@g39088902 g39088902 changed the title Dygraph Fixed some bugs that caused PPOCRLabel to crash, added ability to expand checkboxes Nov 10, 2023
Copy link
Collaborator

@tink2123 tink2123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiyutang shiyutang merged commit d3e362a into PaddlePaddle:dygraph Dec 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants