Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix read-data timer when ignore_data_skip=False and skip_profile_timer=False #8177

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

GuoxiaWang
Copy link
Contributor

…r=False

PR types

Bug fixes

PR changes

Others

Description

fix read-data timer when ignore_data_skip=False and skip_profile_timer=False

Copy link

paddle-bot bot commented Mar 24, 2024

Thanks for your contribution!

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.44%. Comparing base (feb69cf) to head (d586ee7).

Files Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8177      +/-   ##
===========================================
- Coverage    55.44%   55.44%   -0.01%     
===========================================
  Files          596      596              
  Lines        91470    91471       +1     
===========================================
  Hits         50713    50713              
- Misses       40757    40758       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit a33a4f3 into PaddlePaddle:develop Mar 25, 2024
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants