Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pp #8059

Merged
merged 2 commits into from
Mar 6, 2024
Merged

update pp #8059

merged 2 commits into from
Mar 6, 2024

Conversation

lugimzzz
Copy link
Contributor

@lugimzzz lugimzzz commented Mar 6, 2024

PR types

Bug fixes

PR changes

APIs

Description

@lugimzzz lugimzzz requested a review from ZHUI March 6, 2024 07:44
@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Mar 6, 2024

Thanks for your contribution!

@lugimzzz lugimzzz mentioned this pull request Mar 6, 2024
Merged
ZHUI
ZHUI approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 56.53%. Comparing base (32d8b3f) to head (7494082).
Report is 1 commits behind head on develop.

Files Patch % Lines
paddlenlp/transformers/model_utils.py 11.11% 8 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #8059      +/-   ##
===========================================
- Coverage    56.54%   56.53%   -0.01%     
===========================================
  Files          592      592              
  Lines        91073    91079       +6     
===========================================
- Hits         51496    51494       -2     
- Misses       39577    39585       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wawltor
wawltor approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit 67f31c6 into PaddlePaddle:develop Mar 6, 2024
6 of 11 checks passed
@lugimzzz lugimzzz deleted the fix branch March 6, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZHUI ZHUI ZHUI approved these changes

@wawltor wawltor wawltor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lugimzzz @wawltor @ZHUI