[clang-tidy] No. 53,54 enable cppcoreguidelines-c-copy-assignment-signature and bugprone-use-after-move #56601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nature and bugprone-use-after-move
zhangbo9674
reviewed
Aug 24, 2023
| @@ -637,6 +636,7 @@ void ProgramInterpreter::Convert( | |||
| .RecordCapturingDeviceContext(dev_ctx_); | |||
| } | |||
| #endif | |||
| vec_instruction_.emplace_back(op_idx, std::move(op_func_node), *dev_ctx_); | |||
There was a problem hiding this comment.
这里为什么要调整一下顺序？
@zhangbo9674
因为开启了GPU后，op_func_node会在std::move之后调用，并且看到vec_instruction_没有在617-638这块代码里使用，所以调整了一下顺序
zhangbo9674
approved these changes
Aug 29, 2023
BeingGod
pushed a commit
to BeingGod/Paddle
that referenced
this pull request
Sep 9, 2023
…nature and bugprone-use-after-move (PaddlePaddle#56601)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
https://releases.llvm.org/12.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/cppcoreguidelines-c-copy-assignment-signature.html
https://releases.llvm.org/7.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/bugprone-use-after-move.html
赛题四：在飞桨框架中引入 clang-tidy Tracking Issue