Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[phi][jit] clean paddle/phi/kernels/jit Unused methods #51446

Merged
merged 15 commits into from
Mar 17, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Mar 9, 2023

PR types

Others

PR changes

Others

Describe

清理paddle/phi/kernels/jit下未使用的方法

再清理的同时有删除测试方法, 请核对后再合入

refer:

  • Softmax
  • StrideScal
  • NCHW16CMulNC
  • HSum
  • HMax
  • StrideASum

#50911

@paddle-bot
Copy link

paddle-bot bot commented Mar 9, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 9, 2023
@gouzil gouzil changed the title [phi][jit] clean paddle/phi/kernels/jit Unused methods. Please don't join in !!!!! [phi][jit] clean paddle/phi/kernels/jit Unused methods. Please don't Merging !!!! 请先不要合入 Mar 9, 2023
@gouzil gouzil changed the title [phi][jit] clean paddle/phi/kernels/jit Unused methods. Please don't Merging !!!! 请先不要合入 [phi][jit] clean paddle/phi/kernels/jit Unused methods Mar 12, 2023
@YuanRisheng
Copy link
Contributor

jit/gen/act.cc里注册了多个activation kernel,这些都用到了吗

@luotao1
Copy link
Contributor

luotao1 commented Mar 13, 2023

由于核心phi头文件解耦已经在3.13日做完了,多余代码删除的截止日期按照黑客松其他任务的截止时间即可。

@gouzil
Copy link
Member Author

gouzil commented Mar 13, 2023

jit/gen/act.cc里注册了多个activation kernel,这些都用到了吗

目前仅清理完refer。我尽快

@gouzil
Copy link
Member Author

gouzil commented Mar 13, 2023

由于核心phi头文件解耦已经在3.13日做完了,多余代码删除的截止日期按照黑客松其他任务的截止时间即可。

好的,我尽快

@gouzil gouzil force-pushed the clean_phi_kernels_funcs_jit branch 2 times, most recently from 0cd2222 to 4058c25 Compare March 14, 2023 15:58
@luotao1
Copy link
Contributor

luotao1 commented Mar 16, 2023

CI 已过,请 @YuanRisheng 帮忙 review 下

@gouzil
Copy link
Member Author

gouzil commented Mar 16, 2023

jit/gen/act.cc里注册了多个activation kernel,这些都用到了吗

那些被lstm用上了,已经清理完成了

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanRisheng YuanRisheng merged commit 6aa3670 into PaddlePaddle:develop Mar 17, 2023
@gouzil gouzil deleted the clean_phi_kernels_funcs_jit branch March 24, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants