Minor updates #450
Merged
Minor updates #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was recommended in a warning for current BuildX plugin versions.
* Add missing parameter to feedback node for R18 config * Update frame rate and remove extraneous whitespace
| @@ -4,7 +4,7 @@ | |||
| # Assumptions: | |||
| # - ROS_DISTRO is defined with the name of a distribution installed under /opt/ros/ | |||
| # | |||
| ARG ROS_VERSION | |||
| ARG ROS_VERSION="foxy" | |||
There was a problem hiding this comment.
Help me recall: what are the reasons we cannot upgrade from foxy? mmdet was one; were there others?
There was a problem hiding this comment.
I was wondering if we should revisit this
There was a problem hiding this comment.
Right. Noted, thanks.
cameron-a-johnson
approved these changes
Oct 9, 2024
| @@ -4,7 +4,7 @@ | |||
| # Assumptions: | |||
| # - ROS_DISTRO is defined with the name of a distribution installed under /opt/ros/ | |||
| # | |||
| ARG ROS_VERSION | |||
| ARG ROS_VERSION="foxy" | |||
There was a problem hiding this comment.
I was wondering if we should revisit this
|
@Purg - this looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were some recent minor updates I had found in reintroducing myself into various parts of the codebase.