feat: add the ability to disable ils user creation when using sso #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds the ability to disable the creation of users when using SSO for login
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the ability to disable the creation of users when using SSO for login
Test plan:
Set up SSO (for PTFS-> you can use the dev server settings)
In the SSO settings make sure that "Create ILS users when a matching user is not found from the IdP data in the ILS" is disabled
Try logging in with SSO, you should not be able to, should get error that makes sense
Turn on the above
Try logging in again, it should work.
Disable it again
Logging in should still work as the user exists in the ILS now.
Feel free to try deleting the user in Koha to see that the login then does not work again if ils user creation is disabled.