Add objective scaling and other small fixes #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed dependencies for cmake sub project support Fixed some memory leaks Fixed printf format strings etc Fixed compatibility with newer compilers
poolfeast-420
commented
Oct 25, 2024
| @@ -337,8 +337,8 @@ void resize_workspace_vars(Prob& problem, Alg& algorithm, Sol& solution, Workspa | |||
| workspace->x0->resize(nvars,1); | |||
| workspace->lambda->resize(nlp_ncons,1); | |||
|
|
|||
| workspace->xlb->resize(nvars,1); | |||
| workspace->xub->resize(nvars,1); | |||
| *workspace->xlb = MatrixXd::Zero(nvars,1); | |||
There was a problem hiding this comment.
This fixes reading of an un-initialised variable
poolfeast-420
commented
Oct 25, 2024
| @@ -1058,35 +1059,6 @@ int get_iphase_offset(Prob& problem, int iphase,Workspace* workspace); | |||
|
|
|||
| adouble ff_ad(adouble* xad, Workspace* workspace); | |||
|
|
|||
|
|
|||
| void rk4_propagate( void (*dae)(adouble* derivatives, adouble* path, adouble* states, | |||
There was a problem hiding this comment.
These functions have been removed from the source
poolfeast-420
commented
Oct 25, 2024
| constexpr double inf = std::numeric_limits<double>::infinity(); | ||
| constexpr double pi = 4.0*atan(1.0); | ||
| constexpr double inf = std::numeric_limits<double>::infinity(); | ||
| const double pi = 4.0*atan(1.0); |
There was a problem hiding this comment.
On newer compilers constexpr is enforced and atan can't be calculated at compiletime with this c++ version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an objective scaling input.
Which allows overriding just objective without affecting the other automatic scaling numbers.
I changed the cmake slightly to allow sub project to work, (directly linking the target into a bigger cmake project without installing).
I also changed some small things that my linter suggested. Like printf format strings etc.
Let me know if you'd like the objective scaling done a different way perhaps? I'm happy to put a couple hours or so into this.
Thank you for the library! Works well.