validation: Add temporary(?) validation

compiler/plc_driver/src/pipelines/property.rs

@@ -20,7 +20,7 @@ impl PipelineParticipantMut for PropertyLowerer {
         self.annotations = Some(annotations);
 
         for AnnotatedUnit { unit, .. } in &mut units.iter_mut() {
-            self.lower_identifiers_to_calls(unit);
+            self.lower_references_to_calls(unit);
         }
 
         let project = AnnotatedProject { units, index, annotations: self.annotations.take().unwrap() };

src/lowering/property.rs

@@ -28,8 +28,9 @@ impl PropertyLowerer {
         PropertyLowerer { id_provider, annotations: None, context: None }
     }
 }
+
 impl PropertyLowerer {
-    pub fn lower_identifiers_to_calls(&mut self, unit: &mut CompilationUnit) {
+    pub fn lower_references_to_calls(&mut self, unit: &mut CompilationUnit) {
         self.visit_compilation_unit(unit);
     }
 }
@@ -82,6 +83,7 @@ impl AstVisitorMut for PropertyLowerer {
 
                 let _ = std::mem::replace(node, call);
             }
+
             _ => (),
         }
     }
@@ -341,7 +343,7 @@ mod tests {
 
         // Lower
         lowerer.annotations = Some(annotations);
-        lowerer.lower_identifiers_to_calls(&mut unit);
+        lowerer.lower_references_to_calls(&mut unit);
 
         insta::assert_debug_snapshot!(unit.implementations, @r#"
         [
@@ -710,7 +712,7 @@ mod tests {
 
         // Lower
         lowerer.annotations = Some(annotations);
-        lowerer.lower_identifiers_to_calls(&mut unit);
+        lowerer.lower_references_to_calls(&mut unit);
 
         insta::assert_debug_snapshot!(unit.implementations, @r#"
         [

src/validation/statement.rs

@@ -459,6 +459,32 @@ fn validate_reference<T: AnnotationMap>(
 ) {
     // unresolved reference
     if !context.annotations.has_type_annotation(statement) {
+        // XXX: Temporary solution, is there a better way? Technically we could introduce a diagnostic when
+        //      lowering the references to calls, then checking with the index if the defined POU exists but
+        //      then we'd get two similar error, one describing what the exact issue is (i.e. no get/set) and
+        //      the other describing that it cant find a reference to "__{get,set}_<property name>"
+        match ref_name {
+            _ if ref_name.starts_with("__set") => {
+                validator.push_diagnostic(
+                    Diagnostic::new("SET property not defined")
+                        .with_error_code("E048")
+                        .with_location(location),
+                );
+                return;
+            }
+
+            _ if ref_name.starts_with("__get") => {
+                validator.push_diagnostic(
+                    Diagnostic::new("GET property not defined")
+                        .with_error_code("E048")
+                        .with_location(location),
+                );
+                return;
+            }
+
+            _ => (),
+        };
+
         validator.push_diagnostic(Diagnostic::unresolved_reference(ref_name, location));
 
         // was this meant as a direct access?