-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate CBOR_CUSTOM_ALLOC #237
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 20 20
Lines 1543 1543
=======================================
Hits 1478 1478
Misses 65 65
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chenrui333
added a commit
to chenrui333/homebrew-core
that referenced
this pull request
Dec 29, 2022
`CBOR_CUSTOM_ALLOC` got deprecated relates to PJK/libcbor#237 Signed-off-by: Rui Chen <[email protected]>
BrewTestBot
pushed a commit
to Homebrew/homebrew-core
that referenced
this pull request
Dec 29, 2022
* libcbor 0.10.0 * libcbor: update test `CBOR_CUSTOM_ALLOC` got deprecated relates to PJK/libcbor#237 Signed-off-by: Rui Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CBOR_CUSTOM_ALLOC was a mistake, the defaults with CBOR_CUSTOM_ALLOC=ON are compatible with CBOR_CUSTOM_ALLOC=OFF.
I would like to remove it going forward. Will keep this PR open for a few weeks to give people a chance to object.
Pros of having the flag:
Cons:
Also reworked the bazel build example since it was miswired and broke due to the flag change
Checklist