[P2P] Do not fully sort all nodes for addr relay #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
squash the two commits please |
Liquid369
force-pushed
the
2023_relay_sort
branch
from
27d144a to
664b535
Compare
|
Handled. Wanted to be able to hit "resolve" before force pushing 👍 haha |
panleone
approved these changes
Apr 21, 2023
Fuzzbawls
approved these changes
May 21, 2023
Fuzzbawls
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offers some performance improvement when dealing with peers and networking. Rather than creating a map of every address being relayed and picking the top ones, we can just compute the top ones directly. This will save a good amount of the heavy computation and leave it to a quote artimethic
bitcoin#8690