CCrypter using secure allocator vector. #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can be rebased now that #1486 is merged |
Change CCrypter to use vectors with secure allocator instead of buffers on in the object itself which will end up on the stack. This avoids having to call LockedPageManager to lock stack memory pages to prevent the memory from being swapped to disk. This is wasteful. Coming from upstream 999e4c9
furszy
force-pushed
the
2020_crypter_use_secure_allocator
branch
from
596e917 to
f8fd095
Compare
|
rebased, ready for review. |
Fuzzbawls
approved these changes
May 17, 2020
furszy
added a commit
that referenced
this pull request
Apr 5, 2021
1c04a35 [Trivial] Use C++11 nulltpr instead of NULL macro in allocators files (random-zebra) 68a3f8f bench: Add benchmark for lockedpool allocation/deallocation (Wladimir J. van der Laan) cd34088 rpc: Add `getmemoryinfo` call (Wladimir J. van der Laan) 2d2e331 support: Add LockedPool (Wladimir J. van der Laan) 6ca6470 allocators: split allocators and pagelocker (random-zebra) Pull request description: First commit adapts btc d7d187e. Then backport the last 3 commits of bitcoin#8753, which were left out in #1488. ACKs for top commit: Fuzzbawls: ACK 1c04a35 furszy: ACK 1c04a35 . Tree-SHA512: 9ee1100df3648a73e1fcd9b98f7fb793d3eb342ad239d3d4f9b2dd32dc0bacfdb29825e84e4e2ba4e621aedb0a62ae66dfba4d76a435b77dd5e2af1a01541890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #1486. Commits starting in
d058064.This PR back port, partially, upstream@8753 . -- The last three commits left to back port in a future PR --
Containing the following changes:
Changing CCrypter to use vectors with secure allocator instead of have to lock stack memory pages to prevent the memory from being swapped to disk.
Removing the unused LockObject and UnlockObject methods.
Adding a missing lock in the
CCryptoKeyStore::GetKeysmethod.